[stable33] fix(files_sharing): keep matching bundles for shares carrying the federation SHARE permission - #64400
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
…eration SHARE permission Link and email shares get the SHARE permission added by the server whenever `shareapi_allow_federation_on_public_shares` is enabled, which is the default. Comparing their raw permissions against the bundles therefore classified every public share as "Custom permissions" instead of the bundle it was created with. Match against the bundles through a helper that ignores that permission for public shares, while keeping the `exclude_reshare_from_edit` aware comparison for internal shares. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
backportbot
Bot
force-pushed
the
backport/64376/stable33
branch
from
September 15, 2026 21:49
a8c0e34 to
1ee6d5a
Compare
susnux
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64376
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.