Conversation
susnux
force-pushed
the
worktree-remove-dead-postadduser-listener
branch
from
September 15, 2026 20:58
43d01d4 to
b5b36d6
Compare
provokateurin
requested changes
Sep 16, 2026
…ddUser hook The `IGroup::class . '::postAddUser'` event this listener subscribed to is not dispatched anywhere; `\OC\Group\Group` only emits the legacy `\OC\Group`/`postAddUser` signal on the `Emitter`, which never reaches the event dispatcher. Drop the registration together with the now unreachable `Notification\Listener::userAddedToGroup()` and its share manager dependency. Auto-accepting group shares stays covered by `UserAddedToGroupListener`, which listens to the typed `UserAddedEvent`. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
worktree-remove-dead-postadduser-listener
branch
2 times, most recently
from
September 16, 2026 13:58
bd7d128 to
842fa04
Compare
provokateurin
approved these changes
Sep 16, 2026
…roup Reimplements the notification that was lost with the dead postAddUser listener as a listener on the typed UserAddedEvent. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
worktree-remove-dead-postadduser-listener
branch
from
September 16, 2026 14:05
842fa04 to
c72a60f
Compare
cristianscheid
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
there is nothing like IGroup::postUserAdded but only OC\Group::postUserAdded.
So this listener was dead for a while - rewired with the proper event instead.
Checklist
3. to review, feature component)stable32)AI (if applicable)
Tests generated with help of AI!