Skip to content

fix: remove nested items from favorites view on unfavorite - #64267

Open
kristian-zendato wants to merge 1 commit into
masterfrom
fix/unfavorite-nested-favorites
Open

fix: remove nested items from favorites view on unfavorite#64267
kristian-zendato wants to merge 1 commit into
masterfrom
fix/unfavorite-nested-favorites

Conversation

@kristian-zendato

Copy link
Copy Markdown
Contributor

Summary

  • Unfavoriting a nested file or folder from the Favorites view left it in the list without a star until reload.
  • The action only emitted files:node:deleted when node.dirname === '/'. That is the item’s real parent path, not the Favorites view directory. Favorites at / is a virtual listing of all favorites, so nested items (e.g. /Documents/vacation.txt) never left the list.
  • This now checks the current folder instead (folder.path === '/'). Nested items are removed when unfavoriting at the Favorites root. Opening a real folder from Favorites still only removes the star.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato requested review from a team and skjnldsv as code owners September 11, 2026 17:51
@kristian-zendato
kristian-zendato requested review from sorbaugh and susnux and removed request for a team September 11, 2026 17:51
@kristian-zendato kristian-zendato added bug 3. to review Waiting for reviews labels Sep 11, 2026
@solracsf solracsf added this to the Nextcloud 36 milestone Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The unfavorite action on file, doesnt remove the file from the favorite folder

2 participants