fix: preserve link shares on ownership transfer - #64209
Open
salmart-dev wants to merge 3 commits into
Open
Conversation
CommandLine defines both logic to run occ commands in integration tests as wel as behat steps. This is problematic as if two contexts are loaded and both need the ability to run occ commands, they will cause a conflict due to the steps being defined more than once. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/transfer-link-shares
branch
from
September 11, 2026 11:00
8a825d4 to
a7c6dfb
Compare
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
salmart-dev
marked this pull request as ready for review
September 11, 2026 13:40
salmart-dev
requested review from
Altahrim,
CarlSchwan,
leftybournes and
provokateurin
and removed request for
a team
September 11, 2026 13:40
Contributor
Author
|
Test failures are unrelated, both should be caused by #53048, the psalm one has already been addressed, but the issue with the non-cleared cache is not yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue on file ownership transfer, which causes link and email shares to be incorrectly dropped.
Link and email shares get their
parentdatabase column set when they come from a reshare, this is used to delete them once the parent share is deleted. During transfer, all shares related to the transferred content are collected and are, in some cases, deleted. The delete triggers the cascade-delete of link and email shares, so they are effectively lost. This PR sets theparentcolumn of the affected shares tonullbefore the main share is deleted, so that the subsequent handling of those shares updates the owner to the user receiving the transfer.Checklist
3. to review, feature component)stable32)AI (if applicable)