fix(files): pass the strict flag to in_array() - #64201
Merged
Merged
Conversation
#53048 added an in_array() call without $strict after the InArrayStrictChecker psalm rule had landed, so static analysis now fails on every pull request. dirname() always returns a string, so strict comparison does not change behaviour. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
salmart-dev
and removed request for
a team
September 10, 2026 18:42
solracsf
changed the title
solracsf
enabled auto-merge
September 10, 2026 19:28
salmart-dev
approved these changes
Sep 11, 2026
susnux
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
static-code-analysisfailure every pull request currently hits:https://github.com/nextcloud/server/actions/runs/34507108876/job/102971934630?pr=63998
The call came in with #53048 after the strict
in_array()psalm rule landed, and master didn't flag it becausestatic-code-analysisis skipped on master pushes.dirname()always returns a string, so passingtruedoesn't change behaviour.Checklist
3. to review, feature component)stable32)AI (if applicable)