[stable34] feat(share): add public share-review API under OCP\Share\ShareReview#62132
Merged
Conversation
Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…re\ShareReview Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ssCheckEvent Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Replace the time/timestamp string-int duo with a required lastModifiedTimestamp, turn expiration into an expiration timestamp, rename password to hasPassword and model the manage capability as a dedicated flag so the permissions field fits int-mask-of<Constants::PERMISSION_*>. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…bing entries Replace the permissions bitmask on ShareReviewEntry with a list of ShareReviewPermission objects carrying an opaque namespaced identifier and localized display metadata, so apps can expose app-specific permissions without squeezing them into OCP\Constants bits. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
backportbot
Bot
requested review from
Altahrim,
AndyScherzinger,
ArtificialOwl,
CarlSchwan,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
backportbot
Bot
added
enhancement
3. to review
This was referenced Jul 14, 2026
Merged
CarlSchwan
approved these changes
Jul 14, 2026
AndyScherzinger
approved these changes
Jul 14, 2026
provokateurin
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #61543