docs: close a testing-trigger gap for existing-file behavior changes - #133
Open
moodyjmz wants to merge 2 commits into
Open
docs: close a testing-trigger gap for existing-file behavior changes#133moodyjmz wants to merge 2 commits into
moodyjmz wants to merge 2 commits into
Conversation
The commit-discipline rules covered a new unit, a changed function signature, and a bug fix, but not a new interactive element or render branch added to a file that already has specs with no signature change — exactly the shape of gaps found in three recently reviewed PRs (#126, #127, #130). Add that as its own trigger, and fold an extraction-timing signal into the existing "Extraction is its own commit" bullet rather than as a separate paragraph, which read as contradicting it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-discipline rules covered a new unit, a changed function signature, and a bug fix, but not a new interactive element or render branch added to a file that already has specs with no signature change — exactly the shape of gaps found in three recently reviewed PRs (#126, #127, #130). Adds that as its own trigger, and folds an extraction-timing signal into the existing "Extraction is its own commit" bullet rather than as a separate paragraph, which read as contradicting it.
🤖 AI (if applicable)