Fix search box - #1632
Open
sim6 wants to merge 3 commits into
Open
Conversation
Remove unused inputLabel prop from search field Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
Use correct NcSelect event for search option selection. NcSelect in @nextcloud/vue v9 emits 'update:modelValue' instead of 'input'. The old event listeners never fired, so selecting a favorite from the search dropdown did nothing. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
Use keepOpen instead of close-on-select for NcSelect dropdown. NcSelect v9 ignores close-on-select and uses its own keepOpen prop to control dropdown closing behavior. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
9 tasks
Contributor
Author
|
@CarlSchwan Could you review it? |
CarlSchwan
approved these changes
Jul 30, 2026
CarlSchwan
enabled auto-merge
July 30, 2026 14:21
Contributor
Author
|
The test failures are infrastructure-related, not code-related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.