fix: actions menu for envelope#13296
Open
madbob wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! Will try to review soon 🤞 |
| this.hovered = false | ||
| }, | ||
|
|
||
| hideActions() { |
Member
There was a problem hiding this comment.
method still used on L39
Comment on lines
355
to
357
| handleBlur(e) { | ||
| // do not hide if focus is kept within | ||
| if (this.$refs['list-item'].contains(event.relatedTarget)) { |
Comment on lines
+153
to
+164
| // Clicks occurring into the iframe are forced to bubble to the | ||
| // document, to be intercepted by other functions (notably: the | ||
| // global handler of NcActions used to close menus) | ||
| iframeDoc.addEventListener('click', (e) => { | ||
| const replicatedClick = new MouseEvent('click', { | ||
| bubbles: true, | ||
| cancelable: true, | ||
| view: window, | ||
| }) | ||
|
|
||
| document.dispatchEvent(replicatedClick) | ||
| }) |
Member
There was a problem hiding this comment.
I'm a bit skeptical about the impact of this change. Maybe this should be a separate PR.
| :id="anchorId || undefined" | ||
| :aria-label="linkAriaLabel" | ||
| class="list-item__anchor" | ||
| ref="mainCard" |
Signed-off-by: Roberto Guido <info@madbob.org>
Collaborator
Author
|
I've overwritten the previous commit, following the wise notices of @ChristophWurst Highlights:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've simplified a bit the management of actions menu in
EnvelopeSkeleton, to handle the many involved conditions.Notes:
setTimeoutinhandleActionsUpdateOpenis to delay a bit the status change for the closed menu; without it, the flickering menu mentioned in Action menu flickers for some actions #12586 cannot be really fixed. I've already opened an issue for nextcloud-vue in order to have a proper way to manage thisMessageHTMLBody. The (untracked) issue is thatNcActionsregisters a global handler to intercept clicks made on wholedocumentand determines if the opened menu has to be closed, but clicks occurring over the iframe ofMessageHTMLBodyare "absorbed" by the iframe itself and do not bubble to the rest of the document. This change is intended to pre-intercept those clicks and properly deliver them to that global callback: now action menus are closed also when clicking on the HTML body of an email (which often occupies the large portion of the screen). If those changes seem too unrelated to the scope of this PR, I can split them in a different dedicated PREnvelopeSkeletonI've found a few props that are never set by anyone and I guess can be removed.forceDisplayActionshas been here suppressed, whilecounterNumberandcounterTypeare still there. The commit introducing them (0b15b42) provides no hints about their scope. If no-one has any suggestion about their meaning and intended usage, I can remove them within this same PRFixes #12586