Skip to content

feat: update setup script to allow converting existing integration setup to oidc - #1114

Open
Ashim-Stha wants to merge 1 commit into
masterfrom
update-setup-script
Open

feat: update setup script to allow converting existing integration setup to oidc#1114
Ashim-Stha wants to merge 1 commit into
masterfrom
update-setup-script

Conversation

@Ashim-Stha

@Ashim-Stha Ashim-Stha commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • updated integration_oidc_setup.sh so that it converts:
    • existing SSO setup -> SSO setup with given settings
    • existing two-way OAuth setup -> SSO setup with given settings

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@Ashim-Stha Ashim-Stha self-assigned this Jul 13, 2026
@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch 3 times, most recently from 37639ff to 0a0e8c1 Compare July 14, 2026 11:50
saw-jan
saw-jan reviewed Jul 15, 2026
View reviewed changes
Comment thread integration_oidc_setup.sh Outdated
@saw-jan

saw-jan commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Also, target master branch. this is a script change and not a change in app feature.

@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch 6 times, most recently from 45ca2f9 to 5034157 Compare July 21, 2026 10:51
@Ashim-Stha
Ashim-Stha changed the base branch from release/2.11 to master July 23, 2026 05:01
@Ashim-Stha
Ashim-Stha changed the base branch from master to release/2.11 July 23, 2026 05:02
@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch from 5034157 to a97cbbe Compare July 23, 2026 05:48
@Ashim-Stha
Ashim-Stha changed the base branch from release/2.11 to master July 23, 2026 05:48
@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch 6 times, most recently from 6f74200 to bf25af2 Compare July 23, 2026 10:55
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

JS Code Coverage

Coverage after merging update-setup-script into master will be
92.78%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js86.67%33.33%50%88.28%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js67.86%100%25%73.91%10–11, 18–19, 22–23
src/components
   AdminSettings.vue96.53%94.59%100%96.52%228–230, 248–250, 272–280
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue91.85%75%100%93.28%64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOAuthSettings.vue97.61%96.15%93.10%98.10%217, 248, 338, 360, 378–380, 402–404
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormProjectFolder.vue96.55%92.47%97.56%97.22%265, 330, 330–332, 365, 365–366, 378–380, 396–399, 420–422, 479–481
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue97.98%90.91%100%98.82%102–103, 107–108
   SearchInput.vue95.30%92.86%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.72%75%93.75%87.96%116–125, 138–140, 151–155, 165–167, 185–191, 229, 229–234, 234, 234–245, 90–91
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js93.80%92.98%88.89%94.27%100–103, 157–158, 23–25, 54, 54–56, 98–99
src/views
   CreateWorkPackageModal.vue94.31%87.50%90.48%95.40%366–371, 374, 390, 507–510, 515–520, 525–530, 536–539, 542, 599–603, 613–615, 638–639, 647–649, 678–680, 702–704, 713–717
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

PHP Code Coverage

Coverage after merging update-setup-script into master will be
67.90%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   ServerVersion.php0%100%0%0%17, 27–29, 32, 41–42
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php37.04%100%50%36%116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php78.92%100%70.59%79.27%114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 705, 725, 728, 731–746, 760–763, 765–769
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php85.60%100%83.33%85.71%181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
   OpenProjectAPIController.php81.09%100%82.35%80.98%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php40%100%50%37.50%30, 38, 42–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
   UserLoggedInEventListener.php0%100%0%0%27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php0%100%0%0%100–101, 40–42,

@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch from bf25af2 to 55017e2 Compare July 28, 2026 04:01
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch from 55017e2 to b51b1ce Compare July 28, 2026 05:04
@Ashim-Stha
feat: update setup script to allow converting existing integration se…
e16ed95 
…tup to oidc

Signed-off-by: Ashim Shrestha <ashimshrestha2384@gmail.com>
@Ashim-Stha
Ashim-Stha force-pushed the update-setup-script branch from b51b1ce to e16ed95 Compare July 28, 2026 05:10
@Ashim-Stha Ashim-Stha changed the title chore: update setup script feat: update setup script to allow converting existing integration setup to oidc Jul 28, 2026
@Ashim-Stha
Ashim-Stha marked this pull request as ready for review July 28, 2026 05:43
@Ashim-Stha
Ashim-Stha requested a review from saw-jan July 28, 2026 06:07
@nabim777

nabim777 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner
@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner
@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner
@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner
@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner
@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner
@nabim777 nabim777 Awaiting requested review from nabim777 nabim777 is a code owner
@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner
@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner
@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner
@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Ashim-Stha Ashim-Stha

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ashim-Stha @saw-jan @nabim777