Repository navigation
fix(dav): extend the lock expiry on a WebDAV LOCK refresh - #1361
Open
gazziiii777 wants to merge 1 commit into
Open
gazziiii777 wants to merge 1 commit into
gazziiii777 wants to merge 1 commit into
Conversation
A refresh wrote the client's Timeout from the original LOCK instead of from the refresh, so a native WebDAV lock died after the first Timeout regardless of refreshes and every later PUT got 412. Add the elapsed time to the stored lifetime so the expiry moves out from the refresh. Fixes nextcloud#1343 Signed-off-by: gazziiii777 <gazziiii777@gmail.com>
gazziiii777
requested review from
benjaminfrueh and
juliusknorr
as code owners
October 12, 2026 17:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refresh wrote the client's Timeout from the original LOCK instead of from the refresh, so a native WebDAV lock died after the first Timeout regardless of refreshes and every later PUT got 412. Add the elapsed time to the stored lifetime so the expiry moves out from the refresh.
Fixes #1343