Repository navigation
Conversation
- Raise max-version to 35. Without it Nextcloud disables the app during the core upgrade to 35. - Declare the int return type on the execute() methods of the console commands. Symfony Console in Nextcloud 35 declares Command::execute(...): int, and the untyped overrides fail at class load time, which takes down every occ command (exit 255), not only the documentserver ones. Both execute() methods already return an int on every path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
Provide a well signed-off commit, I'll then merge it and release |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nextcloud 35 support. Two separate problems, both hit on a production upgrade from 34 to 35.
1. The app is disabled during the core upgrade
appinfo/info.xmldeclaresmax-version="34"(also in 0.4.0), so the upgrade to 35 switches the app off. The onlyoffice connector then points at a document server that no longer exists:/apps/documentserver_community/healthcheckreturns 404 and documents can't be opened.→
max-versionraised to35.2. Every
occcommand fails once the app is enabled on 35Symfony Console in Nextcloud 35 declares
Command::execute(InputInterface $input, OutputInterface $output): int. The untyped overrides inFlushChangesandFontsfail when the commands are loaded:occloads every app's commands, so this takes down all ofocc(exit 255), not justdocumentserver:*. The web side keeps working (web requests don't load console commands), which makes it easy to miss: the healthcheck is green whileocc upgrade,occ maintenance:modeetc. are broken.→
: intadded to bothexecute()methods. Both already return an int on every path (after the exit-code fix from #398), so there's no runtime change. Related history: #296.Testing
Running these exact three changes on top of the 0.4.0 release, on a production instance:
max-versionbump:occexit 255 with the error above./healthcheckreturnstrue,occ statusexits 0,documentserver:flushanddocumentserver:fontsare registered again, no errors innextcloud.log.Not yet verified on 35: a full editor round-trip (open, edit, save). I'll add a comment once that's done.
Side note for anyone landing here: the onlyoffice connector 10.1.2 is only declared for NC ≤ 34. 10.2.0 (33 to 35) is listed in the app store, but its release download currently returns 404, so it can't be installed yet.
🤖 Generated with Claude Code