Repository navigation
Bump the app version to 0.4.0 - #400
Merged
Merged
Conversation
The bundled document server is Euro-Office rather than ONLYOFFICE DocumentServer as of nextcloud#386, which is a change of what the app ships rather than a fix to how it ships it, so the minor moves. It also carries the two migrations added since v0.3.3 - Nextcloud only replays those when the declared version increases - and the repair step that hands an install configured before nextcloud#387 the format matrix a fresh one is seeded with. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Fabrice Meyer <meyer.fabrice@gmx.fr>
chadek
force-pushed
the
release/v0.4.0
branch
from
September 15, 2026 21:47
916a709 to
9560c7c
Compare
Collaborator
Author
|
Re-verified after rebasing onto Full suite on Nextcloud 34, ONLYOFFICE connector 10.1, bundled Euro-Office 9.3.4: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
appinfo/info.xmlto 0.4.0, for the release that swaps the bundled document server from ONLYOFFICE DocumentServer to Euro-Office.The version has to move for the two migrations added since v0.3.3 to run at all, and for the repair step that hands an install configured before #387 the format matrix a fresh one is seeded with — Nextcloud only replays either when the declared version increases.
Release notes for v0.4.0, everything merged since v0.3.3:
v0.4.0
Document server
v9.3.4-hotfix.1) instead of ONLYOFFICE DocumentServer; the Makefile resolves the release asset through the GitHub API, somake ds_repo=ONLYOFFICE/DocumentServer ds_version=v9.4.0still builds the upstream treesdkjs/common/device_scale.js, which 404'd on every document openSaving
autosave_interval(60 s,0turns it off) — from the editing path itself, so it no longer depends on cron, and no longer depends on anoccprocess having the storage credentials either (Theocc documentserver:flush"workaround" does not work (and cannot work) with external SMB storage; a solution idea is attached in case the root problem cannot be fixed (it has persisted for years). #399) — closes Edits and changes made in Onlyoffice are not synced into Nextcloud #100, closes File changes are shown in OnlyOffice but don't appear in Files app #12, closes OnlyOffice file not saved, file changes lost upon exit #103, closes File are not saved on file system but are only editable in onlyoffice #281, closes Saving/offloading is not happening #366, closes Possible data loss after Document Server connection failure #381occ documentserver:flushno longer consumes a live document's change list: run while somebody was still editing it emptied the log the file is rebuilt from and could delete the document folder under an open session — closes Data loss when executing occ documentserver:flush #398occ documentserver:flushfinishes its sweep past a document that will not assemble, reports failures on stderr, waits for a write already in progress, retries while Nextcloud's file locking holds the file, and exits 0 on successocc documentserver:flush --snapshot: write every open document out without ending any sessiondeleteIndexis answered against the number of changes the document holds rather than the highest index, and an absent or-1index no longer cuts every change in the document — an off-by-one that silently deleted a live change on saveEditing
The "documentType" parameter for the config object is invalid. Please correct it.#331forceSaveStartis answered with the two-part reply the editor accepts, throttled so a client cannot turn every keystroke into a converter run, refused to read-only sessions, and it snapshots rather than flushingasc_coAuthoringDisconnect) no longer ends the document for everybody else — with the live-broadcast fix from v0.3.3, co-authoring now shows other people's typing for the whole session — closes No real coediting #302, closes onlyoffice co editing #288change_indexis retried instead of leaving the connection in a dead transaction, where every later query in the request failed withSAVEPOINT DOCTRINE_n does not existmemcache.distributedsetConversion and fonts
font_selection.binshipped an absolute path to every bundled font as it was on the machine that built the package; when one did not resolve, x2t wrote a PDF with no glyphs and exited 0, so nothing downstream could tell a blank conversion from a good one. The paths are pinned relative at build time now, the same wayAllFonts.jsalready was — closes Major: PDFs exports are BLANK! #371, closes PDF prints are blank - Document Server cant print any fonts #251, closes Open pdf file blank or failed #287AllFonts.jsleft over from the build, so a rebuild that wrote nothing reported success, and it never looked atfont_selection.binat all. It now verifies this run wrote both files, that the write succeeded, and that every pinned path resolves — and refuses up front, naming the file and the user, when it cannot write (the shape of Exception: sh: ../../tools/allfontsgen: not found #145 andSegmentation faultwhile rebuilding fonts #278)Can't load fontfileand logged, rather than discarding the one stream that mentioned itocc documentserver:fontsreturned 1 on success and 0 on failure, so anything scripting it was told the opposite of what happenedSecurity
imgurlsare fetched with Nextcloud's HTTP client instead offopen():file://, loopback, link-local and redirect-to-private are all refused (SSRF / local file read)chmod 777— it holds thex2tbinary the web server executesapi.jsthat was never rendered answers 404 instead of an empty 200Internals
MAX(change_index) WHERE document_id = ?is a lookup rather than a scan — Potentially redundant indices #353Change::$changeIndexis declared and populated —getChangeIndex()returned null from an int-typed method, plus a dynamic property deprecation on PHP 8.4The whole rig suite is green on this branch —
formats,smoke,flush-live,autosave,leave,twotab,coedit,coedit-xlsx,forcesave,chat,pdf— on Nextcloud 34 with ONLYOFFICE connector 10.1 and bundled Euro-Office 9.3.4. Each issue listed above has a comment on it with the test output that covers it.Not fixed in this release, so the saving section above is not read as more than it is: #401 reports that on 0.3.4 a spreadsheet's file on disk can lag behind what the editor shows, and can even go backwards — an edit missing from one write reappearing in a later one. It is open and under investigation; the write path this release adds is what that report is against.
🤖 Generated with Claude Code