fix(index): use the updater EOL dates for supported versions - #15632
Merged
Merged
Conversation
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Fri, 18 Sep 2026 07:53:21 GMT |
skjnldsv
disabled auto-merge
September 18, 2026 07:36
The index claimed 32 was still supported, and labelled both 33 and 32 "last supported stable". Support state came from the release tag of vN.0.0 plus 365 days, which disagrees with the end of life dates the updater serves: 32 reached end of life on 2026-09-10, while the tag date put it at 2026-09-27. The published timestamp is not the announced release date either, and 365 days is not 12 calendar months once the window spans a leap February. detect-versions.php now reads major_versions.json from the updater config, the same source the release tooling derives maintenance from, which also drops one API call per version and the rate limit abort path that came with them. Section roles were derived from the loop index, which only defines 0..3, so a fourth maintained version collided with the "last supported stable" role. Twelve months of support over a four month cadence usually means three maintained majors, but the cadence is not a rule the index should encode. Only the newest and the oldest maintained version are labelled now, so any number of maintained versions in between reads correctly, and verify-index.php fails the build if a label is duplicated or missing. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/index-duplicate-supported-stable-label
branch
from
September 18, 2026 07:43
5b874f4 to
183940d
Compare
skjnldsv
enabled auto-merge
September 18, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index on docs.nextcloud.com listed 32 as supported and labelled both 33 and 32 "This documents the last supported stable version of Nextcloud", visible on the page deployed by #15631.
detect_versions()took the release date from thevN.0.0release tag and added 365 days. That disagrees with the end of life dates the updater serves inmajor_versions.json:32 reached end of life on 2026-09-10, the builder put it at 2026-09-27, so the index kept it in the maintained list for a week. The release tag is the wrong input twice over:
published_atfor v35.0.0 is 2026-09-15T21:40:40Z while the announced date is a day later, and 365 days is not 12 calendar months once a window spans a leap February.So
detect-versions.phpreadsmajor_versions.jsoninstead: maintained is an entry with noeolyet, or one whoseeolhas not passed. That is the same sourceMajorLifecyclein nextcloud-releases/server derives maintenance from, so the index cannot disagree with the updater about what is supported. It also drops one GitHub API call per version and the rate limit abort path that came with them, since the file is a single unauthenticated fetch.The duplicated label was separate. The section role came from the loop index, which
generate_section()only defines for 0 to 3:With four entries, index 2 got
$idx + 1= 3 and index 3 got 3 from the last-element rule, so both rendered the same sentence. Only the newest and the oldest maintained version carry a note now, and the ones between them carry none, so the labels stay correct for any number of maintained majors. Twelve months of support over a four month cadence gives three today, but a change of cadence should not need a change here.conf.pyversion_startgoes 32 → 33 becausebuild-docs.ymlfails the master build when that fallback disagrees withlowest_stable.server/32stops being rebuilt. The deploy step only adds version folders and never prunes, so the existing tree stays and the legacy block keeps linking it, PDFs and ePubs included.☑️ Resolves
No issue filed, spotted on the deployed page from #15631.
🖼️ Screenshots
✅ Checklist
codespellor similar and addressed any spelling issuesRegenerating the index against live data and diffing against the deployed one, the only changes are 32 moving into the legacy block and 34 losing its note:
Both assertions were checked against a deliberately broken index (
note "latest stable" appears 2 times,no version is labelled as the latest stable), and the role assignment against 1, 2, 3, 4 and 5 maintained versions. The Sphinx manuals were not rebuilt, so theconf.pyversion picker change is reasoned about rather than observed:range(33, 35)yields 33 and 34, plus stable 35 and latest 36.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.