Skip to content

Pull iOS stringdicts with default source (part 2) - #959

Merged
mpivchev merged 2 commits into
masterfrom
ios-stringdict-fix2
Jun 19, 2026
Merged

Pull iOS stringdicts with default source (part 2)#959
mpivchev merged 2 commits into
masterfrom
ios-stringdict-fix2

Conversation

@mpivchev

Copy link
Copy Markdown
Contributor

Follow up of #956

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
mpivchev enabled auto-merge June 18, 2026 13:38
@mpivchev
mpivchev disabled auto-merge June 18, 2026 15:24
@mpivchev
mpivchev enabled auto-merge June 18, 2026 15:24
@mpivchev
mpivchev disabled auto-merge June 18, 2026 15:24
@mpivchev
mpivchev enabled auto-merge June 18, 2026 15:24
@mpivchev
mpivchev merged commit a74a9bd into master Jun 19, 2026
3 checks passed
@mpivchev
mpivchev deleted the ios-stringdict-fix2 branch June 19, 2026 05:54
@nickvergessen

nickvergessen commented Jul 30, 2026

Copy link
Copy Markdown
Member
  1. The commit message is not acceptable
  2. This PR breaks the sync because there are no arguments -force and so on, they need 2 dashes
  3. The image was not rebuilt after this was merged, so the above breakage did not yet get deployed…

@mpivchev

mpivchev commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@nickvergessen

  1. You are correct, will be resolved next time
  2. Are you sure? I tested locally and -force is recognized:
image
  1. It was deployed. We tested via forcing transifex sync and it completed successfully.
    Still works to this day:
image

@nickvergessen

Copy link
Copy Markdown
Member

At least per documentation:

root@50c69e62f679:/# tx pull --help
NAME:
   tx pull - tx pull [options] [resource_id...]

USAGE:
   tx pull [command options] [arguments...]

OPTIONS:
   --xliff                             Download translation files in xliff format (default: false)
   --json                              Download translation files in json format (default: false)
   --content_encoding value, -e value  The encoding of the file. This can be one of the following:
    'text', 'base64' (default: "text")
   --mode value, -m value  The translation mode of the downloaded file. This can be one of the following:
    'default', 'reviewed', 'proofread', 'translator', 'untranslated',
    'onlytranslated', 'onlyreviewed', 'onlyproofread', 'sourceastranslation' (default: "default")
   --force, -f                  Force the download of the translationsfiles regardless of whether timestamps on the local computer are newer than those on the server (default: false)
   --languages value, -l value  Download specific languages, comma separated Transifex language codes
   --source, -s                 Download source file only (default: false)
   --translations, -t           Downloads translations files (default) (default: false)
   --disable-overwrite, -d      Whether skip existing files (default: false)
   --keep-new-files             Used with --disable-ovewrite to create new files if file already exists with a '.new' extension. (default: false)
   --skip                       Whether to skip on errors (default: false)
   --use-git-timestamps         Compare local files to their Transifex version by their latest commit timestamps. Use this option, for example, when cloning a Git repository. (default: false)
   --branch value               Push to specific branch (use empty argument '' to use the current branch, if it can be determined) (default: "-1")
   --all, -a                    Whether to download all files (default: false)
   --resources value, -r value  Backwards compatibility with old client to fetch resource ids
   --minimum-perc value         Specify the minimum acceptable percentage of a translation mode in order to download it. (default: -1)
   --workers value, -w value    How many parallel workers to use (max 20) (default: 5)
   --silent                     Whether to reduce verbosity of the output (default: false)
   --pseudo                     Generate mock string translations (default: false)
   --help, -h                   show help (default: false)

But anyway it's fixed now

@mpivchev

Copy link
Copy Markdown
Contributor Author

At least per documentation:

root@50c69e62f679:/# tx pull --help
NAME:
   tx pull - tx pull [options] [resource_id...]

USAGE:
   tx pull [command options] [arguments...]

OPTIONS:
   --xliff                             Download translation files in xliff format (default: false)
   --json                              Download translation files in json format (default: false)
   --content_encoding value, -e value  The encoding of the file. This can be one of the following:
    'text', 'base64' (default: "text")
   --mode value, -m value  The translation mode of the downloaded file. This can be one of the following:
    'default', 'reviewed', 'proofread', 'translator', 'untranslated',
    'onlytranslated', 'onlyreviewed', 'onlyproofread', 'sourceastranslation' (default: "default")
   --force, -f                  Force the download of the translationsfiles regardless of whether timestamps on the local computer are newer than those on the server (default: false)
   --languages value, -l value  Download specific languages, comma separated Transifex language codes
   --source, -s                 Download source file only (default: false)
   --translations, -t           Downloads translations files (default) (default: false)
   --disable-overwrite, -d      Whether skip existing files (default: false)
   --keep-new-files             Used with --disable-ovewrite to create new files if file already exists with a '.new' extension. (default: false)
   --skip                       Whether to skip on errors (default: false)
   --use-git-timestamps         Compare local files to their Transifex version by their latest commit timestamps. Use this option, for example, when cloning a Git repository. (default: false)
   --branch value               Push to specific branch (use empty argument '' to use the current branch, if it can be determined) (default: "-1")
   --all, -a                    Whether to download all files (default: false)
   --resources value, -r value  Backwards compatibility with old client to fetch resource ids
   --minimum-perc value         Specify the minimum acceptable percentage of a translation mode in order to download it. (default: -1)
   --workers value, -w value    How many parallel workers to use (max 20) (default: 5)
   --silent                     Whether to reduce verbosity of the output (default: false)
   --pseudo                     Generate mock string translations (default: false)
   --help, -h                   show help (default: false)

But anyway it's fixed now

Yeah i saw it too. But I guess single dashes are also allowed.

@SystemKeeper

Copy link
Copy Markdown
Contributor

I assume it’s then recognized as the shorthand version (-f /-a) and the rest is just skipped, so it works by chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants