Skip to content

[stable-34.0] Chore/improve clang format configuration - #10676

Merged
mgallien merged 5 commits into
stable-34.0from
backport/10663/stable-34.0
Aug 26, 2026
Merged

[stable-34.0] Chore/improve clang format configuration#10676
mgallien merged 5 commits into
stable-34.0from
backport/10663/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Backport of #10663

Warning, This backport's changes differ from the original and might be incomplete 鈿狅笍

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbot Bot requested review from claucambra and mgallien August 25, 2026 19:44
@backportbot backportbot Bot added this to the 34.0.3 milestone Aug 25, 2026
@mgallien mgallien modified the milestones: 34.0.3, 34.0.4 Aug 26, 2026
switch to ubuntu-26.04 to get more recent clang-format

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should enable clang-format to check for missing braces

this is also limited by its inability to have a full code representation
that is what clang-tidy is made for

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should also improve readibility

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Assisted-by: ClaudeCode:claude-sonnet-5
@mgallien
mgallien force-pushed the backport/10663/stable-34.0 branch from 2676295 to 57b4c30 Compare August 26, 2026 08:39
@mgallien
mgallien marked this pull request as ready for review August 26, 2026 08:39
@mgallien
mgallien enabled auto-merge August 26, 2026 08:40
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10676.zip

Digest: sha256:e6452d99c23095f8e1a250d6a078abc85d67e1c6415d9e4e528006a22be9c0bd

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

@mgallien
mgallien merged commit 5c1d886 into stable-34.0 Aug 26, 2026
24 of 25 checks passed
@mgallien
mgallien deleted the backport/10663/stable-34.0 branch August 26, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant