fix: warnings, - #10623
Conversation
Cleans up compilation warnings: "warning: use of GNU ?: conditional expression extension, omitting middle operand [-Wgnu-conditional-omitted-operand]" Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
…ion. Fix warning of unused variable. Signed-off-by: Camila Ayres <hello@camilasan.com>
|
/backport to stable-34.0 |
|
| screen = NSScreen.mainScreen ?: NSScreen.screens.firstObject; | ||
| NSScreen *const mainScreen = NSScreen.mainScreen; | ||
| screen = mainScreen ? mainScreen : NSScreen.screens.firstObject; |
There was a problem hiding this comment.
Seems like we repeat this a lot, maybe it would be worth just having a small util function to avoid writing lots of
NSScreen *const mainScreen = NSScreen.mainScreen;
screen = mainScreen ? mainScreen : NSScreen.screens.firstObject;
| void Systray::showTrayPopup(WindowPosition position) | ||
| void Systray::showTrayPopup([[maybe_unused]] WindowPosition position) | ||
| { | ||
| if (isOpen()) { | ||
| return; | ||
| } | ||
|
|
||
| if (!isSystemTrayAvailable()) { | ||
| showActivitiesWindow(); | ||
| return; | ||
| } | ||
|
|
||
| #ifdef Q_OS_MACOS | ||
| if (showMacOSTrayPopup(geometry())) { |
There was a problem hiding this comment.
This parameter is only unused in the macOS branch. Maybe we can just use Q_UNUSED within this ifdef?
|
Artifact containing the AppImage: nextcloud-appimage-pr-10623.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
3 participants
Resolves
Cleans up warnings during compilation time.
Checklist
AI (if applicable)