fix: Add support for unified sharing

[nilsding]

TODO

• adapt to recent WIP API changes
• clean up commits
• add tests
• make UI look nice, matching the new style used throughout recent additions (e.g. account wizard redesign, governance dialog)
• integrate with File Provider UIExt

Checklist

• Sign-off message is added to all commits.
• The commit history is clean with no merge commits.
  • How to rebase your commits
  • How to squash commits with rebase
• Uploaded screenshots from before and after for UI changes.
• Documentation has been updated or is not required.
• Backports requested where applicable (critical bugfixes).
• Labels added where applicable (bug/enhancement).
• Milestone added for target version.

AI (if applicable)

• The content of this PR was partly or fully generated using AI
  • I have read the guidelines for AI-assisted contributions.
  • I have read Nextcloud's AI Contribution Policy.

[kra-mo]

From the design side, there are a lot of things I could comment on, but generally, it should be aligned with the mockups:

Can I ask why it diverges so much?

[claucambra]

From the design side, there are a lot of things I could comment on, but generally, it should be aligned with the mockups:

Can I ask why it diverges so much?

Several reasons:

1. The share editing view is not something we can easily design in a specific way. We need to dynamically construct the elements based on the properties provided from the server. That is what you see in imgs 1, 2, 4, 5
2. We have existing styled components that we use in e.g. the setup wizard; if we want to follow a style closer to the mockups, this is IMO out of scope. We'd need to revisit the shared component set

There are some things that are not difficult to change that can be accommodated from the mockups e.g. using the toggle buttons rather than a combo box for permissions. I can implement those

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-10307.zip

Digest: sha256:45e0a1e40d5a3b636762e8e60638762fabae3c6e3b1d9458684cfae5e3ba4275

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
78.4% Coverage on New Code (required ≥ 80%)
355 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[kra-mo]

There are some things that are not difficult to change that can be accommodated from the mockups e.g. using the toggle buttons rather than a combo box for permissions. I can implement those

Thanks, however

The share editing view is not something we can easily design in a specific way. We need to dynamically construct the elements based on the properties provided from the server. That is what you see in imgs 1, 2, 4, 5

This is anticipated by the server implementation. I can suggest discussing with other client developers about how they handle it.

And least for the general layout, it should match. i.e. no "Advanced settings" section, but a separate view for settings.

[claucambra]

@kra-mo current state

[kra-mo]

@claucambra

• These buttons should not have a background. But in general, the separation between internal/external shares should be removed. All shares should be in a single list now, instead of being sectioned.

• The "Advanced settings" heading should be removed.

• Does this string come from the server? In any case, the user should not need to know what ISO 8601 is. Use "YYYY-MM-DD". But it would be best if it was an actual date picker instead of just a text input.

• Avatars should be rounded.

• The padding between rows is really low. This should be increased to at least ~4px.

• This field should be taller to indicate that multi-line text input is possible.

We don't use this icon for sharing. As a fallback, you can use person_add.

• Is there no padding between the divider line and this search entry? It should have some.

• These switches and rows should use the same style as they do in the settings window.