Skip to content

Fix handling of storage that has multiple shared mounts #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christoph-bessei wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix handling of storage that has multiple shared mounts #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4072c84
Fix #254 - Embedding files can fail, when storage has multiple shared…
christoph-bessei Aug 23, 2026
391b4f1
Fix #254 - Embedding files can fail, when storage has multiple shared…
christoph-bessei Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/Controller/QueueController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,12 +290,17 @@ private function getFileSource(QueueFile $document, IRootFolder $rootFolder, Sto
if (empty($mounts)) {
throw new \Exception('Couldn\'t find any mounts for this storage');
}
$userId = $mounts[0]->getUser()->getUID();

try {
$file = $rootFolder->getUserFolder($userId)->getFirstNodeById($document->getFileId());
} catch (NotPermittedException $e) {
throw new \Exception('Not allowed to get user folder');
$file = null;
foreach ($mounts as $mount) {
$userId = $mount->getUser()->getUID();
try {
$file = $rootFolder->getUserFolder($userId)->getFirstNodeById($document->getFileId());
} catch (NotPermittedException $e) {
throw new \Exception('Not allowed to get user folder');

@marcelklehr marcelklehr Sep 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the first mount's user has an inaccessible home folder, mounts 2…N are never tried, and the caller (QueueController.php:126-129) deletes the queue row. That's the exact failure shape the PR set out to fix, just moved from "wrong user" to "broken user". It should continue, and the throw should happen after the loop when nothing resolved.

}
if ($file instanceof File) {
break;
}
}
if (!($file instanceof File)) {
throw new \Exception('File not found or not a file');
Expand Down