Skip to content

[stable32] fix(deps): update @nextcloud/vue to 8.41 so the admin settings page renders again - #1034

Open
oleksandr-nc wants to merge 2 commits into
stable32from
fix/stable32-blank-admin-settings
Open

[stable32] fix(deps): update @nextcloud/vue to 8.41 so the admin settings page renders again#1034
oleksandr-nc wants to merge 2 commits into
stable32from
fix/stable32-blank-admin-settings

Conversation

@oleksandr-nc

Copy link
Copy Markdown
Contributor

Since 32.0.13 the AppAPI admin settings page renders empty. Dependabot PR #915 deduped @nextcloud/l10n to 3.4.1 while @nextcloud/vue stayed on 8.17.1, whose bundled translation code writes to a gettext internal that @nextcloud/l10n 3.2 removed. The script throws TypeError: Cannot read properties of undefined (reading 'catalogs') while loading, so nothing mounts. Only stable32 has this pairing: stable31 still locks @nextcloud/l10n 3.1.0, and stable33 and later use @nextcloud/vue 9.

@nextcloud/vue 8.23 and later work with @nextcloud/l10n 3.2+, so this updates it to 8.41.0, the latest 8.x (server stable32 ships 8.40.0), and recompiles the assets with the Node 16 and npm 8 from engines.

Verified on a stock 32.0.14 with the rebuilt assets: the page renders with its daemon list, the register and details modals open, and there are no console errors; with the shipped assets it fails as described. The regression test for this is in #1033.

…enders again

Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant