chore(CI): fix workflow triggers and regenerate OpenAPI specs on stable35 - #1029
Open
oleksandr-nc wants to merge 2 commits into
Open
chore(CI): fix workflow triggers and regenerate OpenAPI specs on stable35#1029oleksandr-nc wants to merge 2 commits into
oleksandr-nc wants to merge 2 commits into
Conversation
The tests* workflows were carried over from main when the branch was cut: they still trigger only on `main` and check out nextcloud/server at `master`. As a result Tests-OK, Tests-Deploy-OK and TestsSpecial-OK never report on a stable35 PR, and branch protection blocks every merge. Mirrors what was done for stable34 in #873. Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
#989 changed appinfo/info.xml <licence> from `agpl` to `AGPL-3.0-or-later` without re-running `composer run openapi`, so the committed specs are stale and the OpenAPI check fails on every PR. Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
oleksandr-nc
marked this pull request as ready for review
September 11, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR targeting
stable35is currently unmergeable, and theopenapicheck is red on all of them. Neither has anything to do with the PRs' own contents.1.
Tests-OK/Tests-Deploy-OK/TestsSpecial-OKnever reportAll
tests*.ymlworkflows were carried over frommainwhen the branch was cut and still say:A PR based on
stable35never matches, so the workflows never start and their summary jobs never post a status. Since all three are required status checks onstable35, branch protection leaves every PR atmergeable_state: blockedindefinitely. The server checkouts inside them are also stillref: master, so even when run they would have tested against servermaster.#989 adjusted
lint.ymlandphpunit.ymlbut skipped this pass. This change mirrors what #873 did forstable34:branches: [main]→branches: [stable35]ref: master→ref: stable35(nextcloud/serverandnextcloud/notifications;nextcloud/notesstays onmain, as on stable34)-e SERVER_BRANCH=stable35on the sixdocker runinvocations that launch the prebuiltnextcloud-dev-php83image (the nginx and ExApp containers are untouched)phpunit.ymlpush trigger →stable35(its matrix was already correct)2.
openapifails on every stable35 PR#989 changed
appinfo/info.xmlfrom<licence>agpl</licence>to<licence>AGPL-3.0-or-later</licence>without re-runningcomposer run openapi, so the committed specs are stale:"license": { - "name": "agpl" + "name": "AGPL-3.0-or-later" }Regenerated with
composer run openapi(nextcloud/openapi-extractor ^1.8.7); the licence name is the only difference.Not addressed here
Block merges during freezesfails becausenextcloud/serverstable35/version.phpis at35.0.0 RC4. That is the workflow working as intended and will clear once 35.0.0 is released.Note
This will be the first time the deploy/integration suites actually run against server
stable35, so genuine failures may surface. Draft until they are green.