Skip to content

feat(e2ee): support password override for key deletion - #250

Merged
marinofaggiana merged 3 commits into
mainfrom
password-parameter
Aug 25, 2026
Merged

feat(e2ee): support password override for key deletion#250
marinofaggiana merged 3 commits into
mainfrom
password-parameter

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Add support for supplying an optional account password when deleting End-to-End Encryption keys.

The password is forwarded to the authorization header for:

  • Public key and certificate deletion
  • Private key deletion
  • Complete E2EE key deletion

When the supplied password is nil or empty, NextcloudKit continues using the password stored in the current session, preserving the existing behavior.

Motivation

Some E2EE key-management operations may require the user’s account password instead of the password or token stored in the active session.

Allowing callers to provide an explicit password makes these operations work with servers requiring password confirmation without changing the authentication behavior of existing callers.

Testing

  • Verified public key deletion with an explicitly supplied password.
  • Verified private key deletion with an explicitly supplied password.
  • Verified complete E2EE key deletion with an explicitly supplied password.
  • Verified that nil or empty passwords fall back to the current session credentials.
  • Verified that the existing request-header behavior remains unchanged for other API calls.

marinofaggiana and others added 3 commits August 24, 2026 08:20
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana changed the title Added password for e2ee delete keys feat(e2ee): support password override for key deletion Aug 25, 2026
@marinofaggiana
marinofaggiana merged commit 2c86f8b into main Aug 25, 2026
4 checks passed
@marinofaggiana
marinofaggiana deleted the password-parameter branch August 25, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants