Skip to content

dummy-ups: mark failed repeater refreshes stale - #3648

Open
user01010111 wants to merge 3 commits into
networkupstools:masterfrom
user01010111:codex/repeater-freshness
Open

user01010111 wants to merge 3 commits into
networkupstools:masterfrom
user01010111:codex/repeater-freshness

Conversation

@user01010111

Copy link
Copy Markdown
Contributor

After an upstream connection fails or a variable list ends early, dummy-ups can keep serving cached or partial data as fresh. Mark failed refreshes stale, propagate LIST errors, and reject short variable rows before accessing missing fields. Restore freshness only after a complete response, while retaining persistent runtime retries and the existing strict/relaxed startup behaviour.

Adds an optional NIT regression using a loopback source, the real repeater, upsd and upsc. It covers connection loss, incomplete and malformed lists, upstream stale replies, repeated recovery, startup behaviour and unaffected dummy modes. The suite has 15 failing checks before the fix and passes all 56 checks afterwards. Existing focused NIT checks, the warning-clean build, GNU C89 syntax check, documentation and distribution checks also pass.

make check and make distcheck-light passed with a local Aspell supplement for two words already rejected in unchanged documentation; the default runs retain those existing spelling failures. Tested on Linux with disposable endpoints; no hardware validation is claimed. Existing incremental updates and transport timeouts are unchanged.

Prepared with OpenAI Codex using gpt-6-astra.

Mark failed runtime refreshes stale, propagate variable-list termination
errors, and reject short rows before accessing missing fields. Restore
freshness after a complete response while preserving persistent retries
and the strict/relaxed startup contract.

Add optional loopback integration coverage through dummy-ups, upsd and
upsc, and update the driver version, release notes and documentation.

AI assistance: OpenAI Codex using gpt-6-astra.

Signed-off-by: user01010111 <12504630+user01010111@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

A ZIP file with standard source tarball and another tarball with pre-built docs for commit e34ae05 is temporarily available: NUT-tarballs-PR-3648.zip.

@jimklimov jimklimov added Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time labels Sep 15, 2026
@jimklimov jimklimov added this to the 2.8.6 milestone Sep 15, 2026
@jimklimov jimklimov added this to NUT QA Sep 15, 2026
@jimklimov jimklimov moved this to In Progress in NUT QA Sep 15, 2026
@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.)

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants