dummy-ups: mark failed repeater refreshes stale - #3648
Open
user01010111 wants to merge 3 commits into
Open
user01010111 wants to merge 3 commits into
user01010111 wants to merge 3 commits into
Conversation
Mark failed runtime refreshes stale, propagate variable-list termination errors, and reject short rows before accessing missing fields. Restore freshness after a complete response while preserving persistent retries and the strict/relaxed startup contract. Add optional loopback integration coverage through dummy-ups, upsd and upsc, and update the driver version, release notes and documentation. AI assistance: OpenAI Codex using gpt-6-astra. Signed-off-by: user01010111 <12504630+user01010111@users.noreply.github.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit e34ae05 is temporarily available: NUT-tarballs-PR-3648.zip. |
jimklimov
approved these changes
Sep 15, 2026
|
❌ Build nut 2.8.5.5320-master failed (commit a0901bb4ff by @user01010111) |
…ols#3648] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an upstream connection fails or a variable list ends early, dummy-ups can keep serving cached or partial data as fresh. Mark failed refreshes stale, propagate LIST errors, and reject short variable rows before accessing missing fields. Restore freshness only after a complete response, while retaining persistent runtime retries and the existing strict/relaxed startup behaviour.
Adds an optional NIT regression using a loopback source, the real repeater, upsd and upsc. It covers connection loss, incomplete and malformed lists, upstream stale replies, repeated recovery, startup behaviour and unaffected dummy modes. The suite has 15 failing checks before the fix and passes all 56 checks afterwards. Existing focused NIT checks, the warning-clean build, GNU C89 syntax check, documentation and distribution checks also pass.
make checkandmake distcheck-lightpassed with a local Aspell supplement for two words already rejected in unchanged documentation; the default runs retain those existing spelling failures. Tested on Linux with disposable endpoints; no hardware validation is claimed. Existing incremental updates and transport timeouts are unchanged.Prepared with OpenAI Codex using
gpt-6-astra.