Fix/tile units default hidden - #233
Merged
Merged
Conversation
Tiles are narrow by construction, so the "• [unit]" badge competed with the title for the same row and truncated it away, often leaving the badge alone in the header. Gauges, easy pies, numbers, bars, tables and pies all share that header through withTile. hideUnits now starts unset rather than false, and the tile header reads it as `?? true`. Tiles therefore hide the unit unless a chart asks for it, while the full chart header keeps showing it, since an unset value is still falsy there. Setting hideUnits explicitly continues to win in both headers. Tests: the tile header hides the unit by default, shows it when hideUnits is explicitly false, and hides it when explicitly true.
ktsaou
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.