Repository navigation
refactor: use public VM bridge symbols - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cl-cc/vm:symbols.cl-cc-vmto revision99f814e4that exports those bridge symbols.Verification
scripts/with-timeout.pl 900 sbcl --script run-tests.lisp: 1109 passed, 0 skipped, 0 todo, 0 failed, 0 errored.feature-lint:FEATURE-LINT PASS: 21 feature(s), checks 1-7.orphan-tests:found=79 registered=75 allowlisted=4 orphan=0.7e084f7d, the integration baseline passes with its locked VM revision695631a2. Pairing this PR's JavaScript source with that old VM fails to load because the bridge symbols are not exported. Overriding only the umbrella VM input to the required revision99f814e4makes the unchanged umbrella baseline fail atCL-CC/EXPANDpackage load due to aDEEP-COPYconflict, before JavaScript tests load. No umbrella files were changed.