Repository navigation
Stop the triphthong handler writing to stdout, publish from CI - #8
Merged
Merged
Conversation
tripthong_parser printed its input, so any verse with a triphthong leaked a line into the CLI report. The CLI test that pins the report to four lines used a verse without a triphthong; it now has a sibling that uses one. The snapshot recorder no longer needs to redirect stdout. release.yml publishes to PyPI on a published GitHub release, through trusted publishing, so no token is stored in the repository or on a developer machine. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things 2.0.0 should not ship without.
tripthong_parserprinted its input. Any verse containing a triphthong leaked a line into the CLI report:The existing test that pins the CLI to four lines used a verse with no triphthong, so it never caught this. It now has a sibling that uses one. The snapshot recorder no longer has to redirect stdout to keep its own output clean.
release.ymlpublishes to PyPI on a published GitHub release, through trusted publishing. No token is stored in the repository or on anyone's machine; the workflow mints a short-lived one. It builds, runstwine check, and uploads from thepypienvironment.Before the first release, the trusted publisher has to exist on PyPI: owner
neburnodrog, repositoryPyverse, workflowrelease.yml, environmentpypi.🤖 Generated with Claude Code