Skip to content

Modernize coverage upload, TypeScript target, and lockfile - #404

Merged
nebhale merged 3 commits into
mainfrom
modernize-ci-and-tooling
Nov 16, 2026
Merged

nebhale merged 3 commits into
mainfrom
modernize-ci-and-tooling

Conversation

@nebhale

@nebhale nebhale commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Codecov: replace bash <(curl -s https://codecov.io/bash) (deprecated uploader, unpinned script run on every build) with codecov/codecov-action@v7. Authenticates via OIDC (use_oidc: true, job id-token: write) because no CODECOV_TOKEN secret exists. Uploads ./coverage/lcov.info.
  • TypeScript target: set target to ES2024 (was the es2016 default from @tsconfig/recommended). That is the @tsconfig/node24 target; Node 24 is the oldest LTS line with meaningful support left (Node 22 ends 2027-04-30). engines.node stays >=22: ES2024 adds no syntax over ES2022 and Node 22 supports its built-ins. Set directly instead of switching base configs so no new dependency is needed.
  • Lockfile: lockfileVersion 2 → 3, dropping the legacy npm 6 dependencies tree. The packages section is unchanged, so no resolved versions move.

Notes

  • The OIDC upload cannot work on fork or Dependabot PRs; the upload step does not fail CI there (fail_ci_if_error defaults to false). To use a token instead, add CODECOV_TOKEN and swap use_oidc: true for token: ${{ secrets.CODECOV_TOKEN }}.
  • This PR's own CI run is the first real test of the new upload step and of compiling with the new target.

🤖 Generated with Claude Code

nebhale and others added 3 commits November 16, 2026 13:09
Replace the deprecated Codecov Bash uploader, which fetched and ran an
unpinned script on every run, with the official codecov/codecov-action.
Authenticate with OIDC since no upload token is configured.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Raise the compile target from the ES2016 default inherited from
@tsconfig/recommended to ES2024, the target of Node.js 24. Node 24 is
the oldest LTS line with meaningful support remaining (Node 22 ends
2027-04-30). ES2024 adds no new syntax over ES2022 and Node 22 supports
its built-ins, so engines.node stays at >=22.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Drop the legacy npm 6 dependencies tree. The packages section, and so
every resolved version, is unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (6f407d6) to head (85f24e1).
⚠️ Report is 543 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   95.95%   95.14%   -0.82%     
==========================================
  Files           3        3              
  Lines          99      103       +4     
  Branches       18       19       +1     
==========================================
+ Hits           95       98       +3     
  Misses          2        2              
- Partials        2        3       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant