feat: react-native-svg support#126
Draft
marklawlor wants to merge 1 commit into
Draft
Conversation
Member
|
Preemptive review to help triage for the 5.0 release, @marklawlor makes the final call. Since this is Mark's own PR, these are just notes for whenever it gets picked back up. SVG support is in the 5.0 scope, but this branch has drifted. It conflicts with main, wraps only Circle, and the single test is a skip stub. The compiler half already landed on main with passing vendor tests for fill, stroke and stroke width, so what remains is the component wrapper set plus a metro resolver entry for react-native-svg, following the safe area context native and web split, with react-native-svg as an optional peer. It would also be the natural place to fix the styled() stack overflow in nativewind#1820. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.