upkeep(opensearch): migrate to existing/supported versions - #515
Closed
x10an14-nav wants to merge 2 commits into
Closed
upkeep(opensearch): migrate to existing/supported versions#515x10an14-nav wants to merge 2 commits into
x10an14-nav wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The public GraphQL schema removes V1 without a compatibility period and gives V3_3 no clear migration path.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates OpenSearch defaults and fixtures to supported 3.6/2.19 versions and refreshes the Go development environment.
Changes:
- Defaults new OpenSearch instances to 3.6 and updates version mappings.
- Deprecates older schema versions and updates integration fixtures.
- Updates Go/Nix tooling and simplifies OpenSearch status conversion.
File summaries
| File | Description |
|---|---|
internal/thirdparty/aiven/fake.go |
Updates fake service metadata to 3.6. |
internal/persistence/opensearch/queries.go |
Changes the fallback version to 3.6. |
internal/persistence/opensearch/models.go |
Removes V1 support and simplifies status mapping. |
internal/graph/schema/opensearch.graphqls |
Updates and deprecates exposed versions. |
internal/graph/gengql/root_.generated.go |
Regenerates the GraphQL schema output. |
integration_tests/opensearchversion.lua |
Expects 3.6 version metadata. |
integration_tests/opensearch_crud.lua |
Exercises CRUD operations using 3.6. |
integration_tests/k8s_resources/state/dev/myteam/opensearch-myteam-running.yaml |
Updates the running fixture to 3.6. |
integration_tests/k8s_resources/state/dev/myteam/opensearch-myteam-rebalancing.yaml |
Updates the rebalancing fixture to 3.6. |
integration_tests/k8s_resources/state/dev/myteam/opensearch-myteam-poweroff.yaml |
Updates the powered-off fixture to 3.6. |
integration_tests/k8s_resources/simple/dev/slug-1/opensearch.yaml |
Updates the simple fixture to 3.6. |
integration_tests/k8s_resources/opensearch_crud/dev/someteamname/opensearch.yaml |
Updates the CRUD fixture to 3.6. |
integration_tests/k8s_resources/opensearch_crud/dev/someteamname/opensearch_hobbyist.yaml |
Updates the hobbyist fixture to 3.6. |
integration_tests/k8s_resources/issues/dev-gcp/sortteam/opensearches.yaml |
Updates sorting fixtures to 3.6. |
flake.nix |
Updates Go and streamlines shell tooling. |
flake.lock |
Refreshes the pinned nixpkgs revision. |
data/k8s/dev/devteam/another-opensearch.yaml |
Updates development data to 3.6. |
Review details
Suppressed comments (1)
internal/graph/schema/opensearch.graphqls:252
- Removing
V1outright is a breaking change to this public GraphQL enum: existing operations and generated clients that still reference it will fail immediately. Keep it as a deprecated compatibility value with a clear migration path until a versioned breaking release, while rejecting unsupported creation through validation if necessary.
V2 @deprecated(reason: "Use `V2_19` instead")
- Files reviewed: 16/17 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Abandoned after #331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.