fix(vulnerability): remove URGENT priority from sorting and update related documentation - #513
Open
ybelMekk wants to merge 11 commits into
Open
fix(vulnerability): remove URGENT priority from sorting and update related documentation#513ybelMekk wants to merge 11 commits into
ybelMekk wants to merge 11 commits into
Conversation
ybelMekk
force-pushed
the
fix/priority
branch
3 times, most recently
from
September 9, 2026 12:04
63afd89 to
a5c7a60
Compare
…and priority handling
…ITY_URGENT and adjust sorting behavior
… improve error handling
…xploited Bump github.com/nais/v13s/pkg/api to bd6d431 (renames Summary.ActNow to Summary.KevCount, wire-compatible). Remove the always-zero countsByPriority.urgent counter and expose a proper knownExploited count sourced from KevCount instead. Keep severity ints and hasSBOM as deprecated-but-present fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The urgent field is now deprecated and documented as always 0, but its description still says "Known-exploited vulnerabilities that require immediate action", which is misleading for API consumers. Update the field description to reflect that it is kept only for backwards compatibility and always returns 0 at image/summary scope. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ybelMekk
force-pushed
the
fix/priority
branch
from
September 9, 2026 20:39
6178e9c to
070f4db
Compare
ybelMekk
force-pushed
the
fix/priority-remove-urgent-sort
branch
from
September 9, 2026 20:59
5e49252 to
7543172
Compare
…lated documentation
ybelMekk
force-pushed
the
fix/priority-remove-urgent-sort
branch
from
September 9, 2026 21:03
7543172 to
28eb930
Compare
ybelMekk
force-pushed
the
fix/priority
branch
from
September 10, 2026 13:26
bee80e9 to
e73e7e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to fix/priority PR
This branch is stacked on
fix/priority; the PR base is set to that branch, so GitHub will retarget this tomainonce the parent merges. Merge the parent first.This pull request removes the "urgent" vulnerability priority as an order-by field from the vulnerability summary features. This field was deprecated because URGENT depends on a workload's internet exposure, which isn't available when counts are aggregated across workloads at summary scope — so the count is always 0 there and the ordering is a no-op. The change cleans up the codebase by removing all references to this field across the GraphQL schema, generated code, models, and sorting logic.
Technically a breaking GraphQL change (enum value removal), but verified safe:
console-frontendhas zero references toVULNERABILITY_PRIORITY_URGENToutside generated files.CVEPriority.URGENTis untouched — it's still returned per-workload byCVE.priority/WorkloadVulnerability.priority.GraphQL Schema and API Cleanup:
VULNERABILITY_PRIORITY_URGENTorder-by field from the GraphQL schema (vulnerability.graphqls) and the generated Go code (root_.generated.go). [1] [2]Model and Validation Updates:
VulnerabilitySummaryOrderByFieldVulnerabilityPriorityUrgentconstant and all references from the vulnerability models, including the list of valid fields and the validation logic inmodels.go. [1] [2]Sorting and Filtering Logic:
sortfilter.go. [1] [2]