Repository navigation
minimal-crates: blacksmith runners & noq support - #10
Merged
Merged
Conversation
flub
changed the title
flub
marked this pull request as ready for review
October 23, 2026 14:01
5 tasks done
Arqu
reviewed
Oct 28, 2026
|
|
||
| # Blacksmith's Windows image ships no pre-installed MSYS2 (C:\msys64). | ||
| release: true | ||
| # - name: Install Go (required for aws-lc-rs FIPS) |
Contributor
There was a problem hiding this comment.
Can we drop this if its not needed here
Collaborator
Author
There was a problem hiding this comment.
oh yes, forgot to clean up. thanks
Stanley00
pushed a commit
to stanley-fork/noq
that referenced
this pull request
Oct 28, 2026
## Description This moves the minimal-crates tests to the shared workflow. This will allow us to make this test required again as it should no longer fail when we release our own crates. Also triggers the wine and zizmor workflows for the merge queue, so that we can make those required checks as well. ## API Changes n/a ## Notes & open questions Needs a new tag on the workflows repo once n0-computer/workflows#10 is merged. Then pinact and zizmor will be happy here. This will allow us making the min-crates a required check again. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All API changes documented. - [x] `cargo make` passes locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to minimal-crates workflow: