Migrate @kyper/button to MXUI and clean up unused select and selectionbox components#351
Conversation
ash-wright123
left a comment
There was a problem hiding this comment.
LGTM as a base branch, will approve once all the pieces have been merged in.
* remove unsed select code * feat: remove unused @kyper/select component * remove select input --------- Co-authored-by: Clement Mwimo <clement.mwimo@mx.com>
I think we can just merge this right? |
I was planning to use it as the base branch and merge everything else into it as the PRs get approved then merge it later. |
I think it makes sense to use a base branch if we can't merge it without other things breaking. Like if we were migrating to MXUI v2 and we needed to check each piece of the UI individually in each PR, and the only way to do the upgrade was to change a ton of stuff. As far as I can tell nothing will break if this is merged, so we should just merge it. Disagree? |
Yes, nothing will break but I think it makes more sense to combine all of the smaller Kyper component migrations that don't introduce any visual changes along with the cleanup only changes into a single release instead of releasing each small piece separately. That way, we can take one release to prod and seek moratorium approval with minimal to no risk, and if anything goes wrong we only have one release to roll back. Thoughts? |
Personally I'd just merge it, but if you want to do it this way you can. |
* feat: remove @kyper/selectionbox * remove remaining @kyper/selectionbox reference --------- Co-authored-by: Clement Mwimo <clement.mwimo@mx.com>
Before(Kyper)
After(MXUI)