Skip to content

Migrate @kyper/button to MXUI and clean up unused select and selectionbox components#351

Merged
mwclemy merged 7 commits into
masterfrom
cmwimo/CT-2383
Jul 16, 2026
Merged

Migrate @kyper/button to MXUI and clean up unused select and selectionbox components#351
mwclemy merged 7 commits into
masterfrom
cmwimo/CT-2383

Conversation

@mwclemy

@mwclemy mwclemy commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Before(Kyper)

Screenshot 2026-07-15 at 13 01 04 Screenshot 2026-07-15 at 13 16 01

After(MXUI)

Screenshot 2026-07-15 at 14 06 56 Screenshot 2026-07-15 at 14 07 28

@ash-wright123 ash-wright123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a base branch, will approve once all the pieces have been merged in.

wesrisenmay-mx
wesrisenmay-mx previously approved these changes Jul 16, 2026

@wesrisenmay-mx wesrisenmay-mx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it

* remove unsed select code

* feat: remove unused @kyper/select component

* remove select input

---------

Co-authored-by: Clement Mwimo <clement.mwimo@mx.com>
@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator

LGTM as a base branch, will approve once all the pieces have been merged in.

I think we can just merge this right?

@mwclemy

mwclemy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM as a base branch, will approve once all the pieces have been merged in.

I think we can just merge this right?

I was planning to use it as the base branch and merge everything else into it as the PRs get approved then merge it later.

@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator

LGTM as a base branch, will approve once all the pieces have been merged in.

I think we can just merge this right?

I was planning to use it as the base branch and merge everything else into it as the PRs get approved then merge it later.

I think it makes sense to use a base branch if we can't merge it without other things breaking. Like if we were migrating to MXUI v2 and we needed to check each piece of the UI individually in each PR, and the only way to do the upgrade was to change a ton of stuff.

As far as I can tell nothing will break if this is merged, so we should just merge it. Disagree?

@mwclemy

mwclemy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM as a base branch, will approve once all the pieces have been merged in.

I think we can just merge this right?

I was planning to use it as the base branch and merge everything else into it as the PRs get approved then merge it later.

I think it makes sense to use a base branch if we can't merge it without other things breaking. Like if we were migrating to MXUI v2 and we needed to check each piece of the UI individually in each PR, and the only way to do the upgrade was to change a ton of stuff.

As far as I can tell nothing will break if this is merged, so we should just merge it. Disagree?

Yes, nothing will break but I think it makes more sense to combine all of the smaller Kyper component migrations that don't introduce any visual changes along with the cleanup only changes into a single release instead of releasing each small piece separately.

That way, we can take one release to prod and seek moratorium approval with minimal to no risk, and if anything goes wrong we only have one release to roll back. Thoughts?

@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator

LGTM as a base branch, will approve once all the pieces have been merged in.

I think we can just merge this right?

I was planning to use it as the base branch and merge everything else into it as the PRs get approved then merge it later.

I think it makes sense to use a base branch if we can't merge it without other things breaking. Like if we were migrating to MXUI v2 and we needed to check each piece of the UI individually in each PR, and the only way to do the upgrade was to change a ton of stuff.
As far as I can tell nothing will break if this is merged, so we should just merge it. Disagree?

Yes, nothing will break but I think it makes more sense to combine all of the smaller Kyper component migrations that don't introduce any visual changes along with the cleanup only changes into a single release instead of releasing each small piece separately.

That way, we can take one release to prod and seek moratorium approval with minimal to no risk, and if anything goes wrong we only have one release to roll back. Thoughts?

Personally I'd just merge it, but if you want to do it this way you can.

* feat: remove @kyper/selectionbox

* remove remaining @kyper/selectionbox reference

---------

Co-authored-by: Clement Mwimo <clement.mwimo@mx.com>
@mwclemy mwclemy changed the title Migrate @kyper/button to MXUI Migrate @kyper/button to MXUI and clean up unused select and selectionbox components Jul 16, 2026
@mwclemy
mwclemy merged commit 1612e82 into master Jul 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants