Repository navigation
feat(core)!: require encryption and migrate configuration on the v17.1.0 baseline - #2924
Conversation
BREAKING CHANGE: Remove ENCRYPT_ALGORITHM, --encrypt_algorithm and YAML encrypt_algorithm. Field writes use fixed AES-256-GCM; only the default ECB legacy reader remains. Custom legacy algorithms require conversion on the prior version before upgrading.
SafeDep Report SummaryPackage Details
This report is generated by SafeDep GitHub App |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 35876281 | Triggered | Generic Encryption Key | adee770 | .github/workflows/release.yml | View secret |
| 35876281 | Triggered | Generic Encryption Key | b733fac | .github/workflows/release.yml | View secret |
| 35876281 | Triggered | Generic Encryption Key | b733fac | .github/workflows/ci.yml | View secret |
| 35876281 | Triggered | Generic Encryption Key | b733fac | .github/workflows/ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e3e0dd1c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| key: resolveDevelopmentEncryptionKey( | ||
| argv.encrypt_key || '', | ||
| isDev, | ||
| path.join(process.cwd(), 'tmp'), |
There was a problem hiding this comment.
Store the development encryption key outside the cleanup directory
When running in development without an explicit encryption key, this puts the only persisted key inside TEMP_DIR (apps/core/src/constants/path.constant.ts). However, CronBusinessService.cleanTempDirectory() recursively deletes that entire directory, and cron-task.scheduler.ts schedules that operation daily at 3 AM without excluding development. After cleanup, the next restart generates a different key, making previously encrypted configuration and other stored credentials unreadable and potentially blocking startup. Store the key outside the cleanup tree or explicitly preserve it during cleanup.
Useful? React with 👍 / 👎.




Summary
Integrates the v18-only work from #2914 onto the v17.1.0 baseline, so the v17.0.5/v17.1.0 fixes (password credential account IDs,
20261113-credential-account-ids, dependency bumps, validation patches) are kept. Supersedes #2914.master.release.yml: tags containing-are marked prerelease, do not movelatest/ major / minor image tags, and do not trigger the production redeploy. The Docker smoke step now receives the required secrets.Verification
pnpm typecheck, admintsc --noEmit,lint:migrations(50 files): pass.upgrade:checkready; re-running migrate changes nothingupgrade:preparethen v18 migrate: API keys, accounts, snippets and webhooks byte-identical across the v18 migratecanonical-configwith exit 1, no rows changed, no ledger rowNot verified
release.ymlprerelease conditions have not run in CI yet.Remaining before release