Stats PR B: survey pagination + chip labels + copy - #32
Merged
Conversation
Paginate personal and teacher Stats like survey modals with progress dots, replace class titles with ClassNameChip, shorten copy, and use decorated StatsAlert for empty/unavailable/error states. Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
Keep the existing Back control copy and neutralize bottom_actions button styles on survey progress dots so they match Modal surveys. Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vue-only Stats restyle (PR B), building on merged PR A (
ClassNameChip/color.ts):StatsModalandTeacherStatsModalwith Modal progress dots (progress_display/__dot/dot_*tokens) via sharedStatsProgressDotsClassNameChipStatsAlert(icon + text), not bareoverlay_contents_textFilterBar + Apex/
StatsChartCardchrome unchanged (filters on chart pages so they keep working across class pages). Data/API unchanged.Files
src/views/Portal/StatsModal.vuesrc/views/Portal/TeacherStatsModal.vuesrc/components/Portal/Stats/StatsAlert.vue(new)src/components/Portal/Stats/StatsProgressDots.vue(new)Out of scope
Test plan
npm run lint(with.envfrom.env.test)npm run build