Stats PR A: color contrast helpers + ClassNameChip - #31
Merged
Conversation
Add pure mix-against-page-bg and WCAG-ish readable text helpers, a reusable ClassNameChip matching overlay chip styles, unit tests wired into CI, and a minimal ViewTask proof swap. Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vue-only foundation for Stats chip restyle (PR A):
src/common/color.ts— pure helpers to mix class color against flat page--color-bg(opaque hex, not+ '2d'alpha) and pick a readable foreground (~WCAG 4.5:1 when possible).src/components/Portal/ClassNameChip.vue— overlay chip markup/CSS (button_pointer_text class_name, padding/radius tokens), wires mix + text into--color-class/--color-class-alt, reads live--color-bgfor theme toggle.ClassNameChip(same link behavior).npm run test:color+ CI step.Out of scope
Test plan
npm run test:colornpm run lint