Fix EditTask/NotesTask rejecting canonical classId~taskId refs - #30
Merged
Conversation
Router now canonicalizes flat task refs to two segments; the get_task guards still required three slash parts. Accept parseTaskId-valid refs (including classId~taskId) and reject empty/class-only/malformed. Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #28. Edit-one smoke failed because
EditTask.vue(andNotesTask.vue) still required three slash segments after converting~→/. The router now canonicalizes task refs to two-segmentclassId~taskId, so every edit/notes load hitInvalid task specified.Guards now use
isValidTaskRouteRef(parseTaskId): acceptclassId~taskId/classId/taskId/ legacy 3-segment, reject empty, class-only,email/classId, and extra segments. Earlyreturnafter close so we do not keep fetching.Files
src/common/paths.tsisValidTaskRouteRefsrc/views/Portal/EditTask.vuesrc/views/Portal/NotesTask.vuescripts/test-paths.mjs.github/workflows/ci.ymltest:pathsOut of scope
Server, nested delete, repeating-scope behavior.
Test plan
npm run test:paths(includesisValidTaskRouteRef)lint, existing tests,test:paths,build)classId~taskId— noInvalid task specified