Skip to content

Not checking for missing attributes in GDTFManager::GdtfDmxChannel::GetName() #153

Description

@pedromagalhae

Issue is in GDTFManager::GdtfDmxChannel::GetName(), line 5504:
If fLogicalChannels[0]->GetAttribute() returns nullptr, GetName() will fail.

Checking for nullptr prevents the crash, something like:
if(fLogicalChannels.size() > 0 && fLogicalChannels[0]->GetAttribute()) (...)

But maybe you'd like to handle this error differently.

Attached a description.xml file which is missing the ColorAdd_W attribute.

description.xml

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions