-
Notifications
You must be signed in to change notification settings - Fork 47
Updater. New Flow #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eism
wants to merge
13
commits into
musescore:main
Choose a base branch
from
Eism:updater
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updater. New Flow #240
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56dc92e
added update helper
Eism bcc0609
added download update in the background
Eism 54ae566
added updater for windows
Eism dc4e09b
added updater for linux
Eism 27abb83
refactor update process for improved robustness and atomicity
Eism 0e5499f
updated the update dialog
Eism fdfa43b
refine update package management and download mechanisms
Eism 3e76731
added UI for install helper on Windows
Eism cb8776d
updated stub for module
Eism 2008f28
tmp fix
Eism ddcfce5
use dmg for macOS
Eism baadbed
split update installation into prepare and finalize phases
Eism 2c37fe3
fixed sign check on windows
Eism File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # SPDX-License-Identifier: GPL-3.0-only | ||
| # MuseScore-Studio-CLA-applies | ||
| # | ||
| # MuseScore Studio | ||
| # Music Composition & Notation | ||
| # | ||
| # Copyright (C) 2026 MuseScore Limited and others | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License version 3 as | ||
| # published by the Free Software Foundation. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| muse_create_qml_module(muse_update_qml ALIAS muse::update_qml FOR muse_update STUB) | ||
|
|
||
| qt_add_qml_module(muse_update_qml | ||
| URI Muse.Update | ||
| VERSION 1.0 | ||
| QML_FILES | ||
| UpdateBanner.qml | ||
| ) | ||
|
|
||
| fixup_qml_module_dependencies(muse_update_qml) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * SPDX-License-Identifier: GPL-3.0-only | ||
| * MuseScore-CLA-applies | ||
| * | ||
| * MuseScore Studio | ||
| * Music Composition & Notation | ||
| * | ||
| * Copyright (C) 2026 MuseScore Limited and others | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License version 3 as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
| import QtQuick | ||
|
|
||
| Item { | ||
| readonly property bool hasReadyUpdate: false | ||
| readonly property string updateVersion: "" | ||
|
|
||
| visible: false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| # SPDX-License-Identifier: GPL-3.0-only | ||
| # MuseScore-Studio-CLA-applies | ||
| # | ||
| # MuseScore Studio | ||
| # Music Composition & Notation | ||
| # | ||
| # Copyright (C) 2026 MuseScore Limited and others | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License version 3 as | ||
| # published by the Free Software Foundation. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| set(UPDATE_HELPER_TARGET museupdater) | ||
|
|
||
| set(UPDATE_HELPER_SRC | ||
| main.cpp | ||
| platform.h | ||
| ) | ||
|
|
||
| if (OS_IS_WIN) | ||
| list(APPEND UPDATE_HELPER_SRC | ||
| platform_win.cpp | ||
| updatetask_win.cpp | ||
| updatetask_win.h | ||
| updateui_win.cpp | ||
| updateui_win.h | ||
| ../internal/platform/win/winupdateshared.h | ||
| ) | ||
| else() | ||
| list(APPEND UPDATE_HELPER_SRC | ||
| swap.cpp | ||
| swap.h | ||
| ) | ||
|
|
||
| if (OS_IS_MAC) | ||
| list(APPEND UPDATE_HELPER_SRC platform_mac.cpp) | ||
| else() | ||
| list(APPEND UPDATE_HELPER_SRC platform_unix.cpp) | ||
| endif() | ||
| endif() | ||
|
|
||
| add_executable(${UPDATE_HELPER_TARGET} ${UPDATE_HELPER_SRC}) | ||
|
|
||
| set_target_properties(${UPDATE_HELPER_TARGET} PROPERTIES | ||
| CXX_STANDARD 17 | ||
| CXX_STANDARD_REQUIRED ON | ||
| ) | ||
|
|
||
| if (OS_IS_LIN) | ||
| # The helper is copied out of the AppImage and runs after it has been | ||
| # unmounted, so it cannot rely on the libraries bundled inside it. Those are | ||
| # generally newer than what the host provides, and linking against them | ||
| # dynamically would make the helper fail to start on exactly the systems | ||
| # where it is needed. | ||
| if (CC_IS_GCC OR CC_IS_CLANG) | ||
| target_link_options(${UPDATE_HELPER_TARGET} PRIVATE -static-libstdc++ -static-libgcc) | ||
| endif() | ||
| endif() | ||
|
|
||
| if (OS_IS_WIN) | ||
| target_link_libraries(${UPDATE_HELPER_TARGET} PRIVATE | ||
| taskschd # CLSID_TaskScheduler, IID_ITaskService, IID_IExecAction | ||
| ole32 # CoInitializeEx, CoCreateInstance | ||
| oleaut32 # SysAllocString, VariantInit | ||
| advapi32 # registry, security descriptors, DuplicateTokenEx, CreateProcessAsUserW | ||
| shell32 # CommandLineToArgvW | ||
| wintrust # WinVerifyTrust and the WTHelper* signer accessors | ||
| crypt32 # CertGetNameStringW | ||
| userenv # CreateEnvironmentBlock | ||
| wtsapi32 # WTSQueryUserToken | ||
| msi # MsiInstallProductW and the external UI handler | ||
| user32 # the progress window | ||
| gdi32 # and what it is drawn with | ||
| ) | ||
| endif() | ||
|
|
||
| # On macOS the helper is embedded into the app bundle by the app target. | ||
| if (NOT OS_IS_MAC) | ||
| set(UPDATE_HELPER_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}") | ||
| if (NOT UPDATE_HELPER_INSTALL_DIR) | ||
| # GNUInstallDirs is not necessarily in use; the application itself is | ||
| # installed into "bin" and the helper has to sit next to it. | ||
| set(UPDATE_HELPER_INSTALL_DIR "bin") | ||
| endif() | ||
|
|
||
| install(TARGETS ${UPDATE_HELPER_TARGET} | ||
| RUNTIME DESTINATION ${UPDATE_HELPER_INSTALL_DIR} | ||
| ) | ||
| endif() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: musescore/muse_framework
Length of output: 13179
🏁 Script executed:
Repository: musescore/muse_framework
Length of output: 3361
🏁 Script executed:
Repository: musescore/muse_framework
Length of output: 5661
Guard the stub QML subdirectory with
MUSE_MODULE_UPDATE_QML.The real and stub modules use the same QML option. Add the same condition before
add_subdirectory(qml/Muse/Update)inframework/stubs/update/CMakeLists.txt.🤖 Prompt for AI Agents