Cleanups: remove unused member and fix double-subscribe assertion failure

[cbjeukendrup]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 515d97ae-32ce-4e32-ab48-27756f2ff86a

📥 Commits

Reviewing files that changed from the base of the PR and between 6b68880 and f1f312a.

📒 Files selected for processing (2)

• src/engraving/rendering/score/layoutcontext.h
• src/notationscene/qml/MuseScore/NotationScene/playbackcursor.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The layout context header now uses #pragma once instead of a traditional include guard. PlaybackCursor::setNotation now disconnects the previous notation’s viewModeChanged handler when the notation changes or is cleared.

Merge Risk: ⚪ Minimal · up to f1f31

This localized cleanup removes an unused member and addresses a double-subscribe assertion failure; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description, so it omits the required issue reference, change summary, and checklist responses.	Add the required issue reference, a short motivation and change summary, and accurate responses for every checklist item.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes both main changes: removing an unused member and fixing the double-subscribe assertion failure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}