normalise fret diagram keys

[alexpavlov96]

follow up of less broad fix https://github.com/musescore/MuseScore/pull/34498/changes

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cf359c67-051f-4f5f-9c00-cfc3373d1ce5

📥 Commits

Reviewing files that changed from the base of the PR and between 75647f6 and 451334f.

📒 Files selected for processing (1)

• src/engraving/dom/fret.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change replaces fixed enharmonic TPC mappings with arithmetic normalization across all pitch classes. Harmony-to-diagram map entries now canonicalize valid root and bass TPC values before insertion. Lookup and map population therefore use the same canonical TPC representation.

Merge Risk: ⚪ Minimal · up to 45133

This localized change has no identified merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only references a prior pull request and omits the required issue, change summary, motivation, and checklist information.	Add the resolved issue, a summary and motivation, and complete each applicable checklist item.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: normalizing fret diagram keys.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}