Skip to content

Fix lyric positioning relative to staff-centred dynamic - #34636

Open
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:lyrics-position
Open

Fix lyric positioning relative to staff-centred dynamic#34636
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:lyrics-position

Conversation

@ajuncosa

Copy link
Copy Markdown
Contributor

Resolves: #31227

…n SystemLayout::elementHasAnotherStackedOutside()
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 92c7ceb3-f75b-4d7b-90c7-da9cf788e4a6

📥 Commits

Reviewing files that changed from the base of the PR and between 7cf266f and 0ca0f74.

📒 Files selected for processing (1)
  • src/engraving/rendering/score/textlayout.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

High-resolution character bounds added during text layout now retain the originating TextBase item as their owner. The previous ownerless insertion was removed.

Merge Risk: ⚪ Minimal · up to 0ca0f

This is a narrowly scoped lyric-positioning adjustment with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description identifies issue #31227 but omits the required summary, motivation, and checklist completion. Add a short change summary and complete all applicable checklist items, including CLA, testing, coding rules, and test coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the lyric positioning bug addressed by the pull request.
Linked Issues check ✅ Passed The ownership pointer added to TextHighResShape directly supports the stacking logic required to fix lyric positioning in issue [#31227].
Out of Scope Changes check ✅ Passed The single code change is directly related to the lyric and staff-centred dynamic positioning issue [#31227].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ajuncosa
ajuncosa requested a review from miiizen August 19, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor vertical positioning for lyrics colliding with staff-centered dynamics

3 participants