Translations: Replace line numbers with occurrence count in source TS - #34618
Open
shoogle wants to merge 2 commits into
Open
Translations: Replace line numbers with occurrence count in source TS#34618shoogle wants to merge 2 commits into
shoogle wants to merge 2 commits into
Conversation
shoogle
marked this pull request as ready for review
August 18, 2026 04:57
This comment was marked as resolved.
This comment was marked as resolved.
shoogle
marked this pull request as draft
August 18, 2026 14:51
shoogle
force-pushed
the
ts-line-counts
branch
from
August 19, 2026 02:23
6b682c3 to
f9aa6aa
Compare
shoogle
marked this pull request as ready for review
August 19, 2026 02:25
shoogle
force-pushed
the
ts-line-counts
branch
from
August 19, 2026 02:51
f9aa6aa to
8fc86ef
Compare
shoogle
commented
Aug 19, 2026
shoogle
force-pushed
the
ts-line-counts
branch
from
August 19, 2026 04:38
8fc86ef to
a05ae52
Compare
shoogle
force-pushed
the
ts-line-counts
branch
from
August 19, 2026 04:54
a05ae52 to
ac6739a
Compare
shoogle
force-pushed
the
ts-line-counts
branch
from
August 19, 2026 05:04
ac6739a to
6fcf4a3
Compare
igorkorsukov
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes PRs like this one easier to review:
That PR added 9 strings but they are buried in the diff, which mostly shows unimportant changes to line numbers.
By removing line numbers from TS files (or replacing them with an occurrence count, which rarely changes), future translation PRs will have a smaller diff that only includes relevant information.
Here's what the current PR actually does to the
*_en.tsfiles.Extract from
share/locale/instruments_en.tsFilenames are now relative to the repository root. Each string occurs once so the line number is now always
1.Extract from
share/locale/musescore_en.tsFilenames are now relative to the repository root. "Undo" & "Redo" each appear 4 times in
notationuiactions.cppso their line number is now4for that file, and1for other files where the strings only appear once.It's only necessary to update the
*_en.tsfiles. After these are uploaded to Transifex, the changes will propagate to TS files in other languages.None of these changes impact Qt tools. While
lupdatedoes read our modified TS file, it only does so to:Crucially,
lupdatereplaces all location data in the old TS file with fresh location data extracted from the C++ source code (or no location in the case of obsolete strings), so our modified locations are never used.Alternative solution: