Skip to content

fix: correct Logging error occurred typo in local.go - #429

Open
Jah-yee wants to merge 1 commit into
multycloud:mainfrom
Jah-yee:fix-local-typo
Open

Jah-yee wants to merge 1 commit into
multycloud:mainfrom
Jah-yee:fix-local-typo

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Jul 2, 2026

Copy link
Copy Markdown

Fixes a typo in api/aws/local.go line 57: 'Logging error ocurred' → 'Logging error occurred'

Note: A previous PR (#428) attempted to fix this and additional instances in api/aws/s3.go, but was closed due to GitHub infrastructure issues (mergeable_state=blocked with no actual checks running). The s3.go instances from that PR remain unfixed as well; this PR only addresses the local.go instance.

Fixes 'Logging error ocurred' in api/aws/local.go
and 'an error ocurred' in api/aws/s3.go
@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

Helpful fix! This would be great to have merged. 👍

@Jah-yee

Jah-yee commented Oct 27, 2026

Copy link
Copy Markdown
Author

Following up on the ocurred -> occurred spelling in the logging paths of this PR. The diff covers four log.Printf strings across two files: api/aws/local.go (UpdateQPSMetric of the local client) and api/aws/s3.go (UpdateQPSMetric plus UpdateErrorMetric, including the CloudWatch error branches). Those lines are written straight to the server log, so the misspelling shows up exactly where you read output when debugging QPS or CloudWatch metric updates. I left the function signatures, the CloudWatch namespace multy/server/, and the error-handling flow untouched, so the change is purely textual. If you would prefer the messages reworded instead of corrected, I can adjust that.

@Jah-yee

Jah-yee commented Nov 5, 2026

Copy link
Copy Markdown
Author

Following up on the spelling correction in the LocalClient logging path.

In local.go, UpdateQPSMetric logged failures with the message [WARNING] Logging error ocurred: %s whenever logAction(...) returned an error; the patch changes ocurred to occurred so the warning text is spelled correctly. The same spelling also appears in the sibling Client.UpdateQPSMetric implementation further down the file, and both call sites are updated in this PR so the two variants of the same warning stay consistent.

The change is string-only: the log.Printf call, the %s verb, and the error flow (return err) are untouched, so behaviour is unchanged. If you would prefer this as part of a broader message-wording cleanup, let me know and I am happy to drop it from this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant