Repository navigation
wasmer 7.5 upgrade in experimental executor - #96
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Local metering can miscalculate costs when a 64-bit unmetered-local threshold is narrowed to u32, and the new metering path lacks coverage.
2 open findings
What changed in this PR
Upgrades the experimental executor to Wasmer 7.5 while aligning local limits and metering across executors.
Changes:
- Updates Wasmer dependencies and middleware lifetimes.
- Shares the 4,000-local limit and implements experimental local metering.
- Adds boundary tests for both executors.
| File | Description |
|---|---|
vm-executor/src/lib.rs |
Exports the shared local limit. |
vm-executor/src/compilation_options.rs |
Defines the 4,000-local limit. |
vm-executor-wasmer/src/wasmer_metering.rs |
Uses the shared limit. |
vm-executor-wasmer/tests/locals_test.rs |
Tests legacy executor boundaries. |
vm-executor-experimental/Cargo.toml |
Upgrades Wasmer to 7.5. |
vm-executor-experimental/src/middlewares/we_breakpoints.rs |
Adapts middleware lifetimes. |
vm-executor-experimental/src/middlewares/we_metering.rs |
Adds local limits and metering. |
vm-executor-experimental/src/middlewares/we_opcode_control.rs |
Adapts middleware lifetimes. |
vm-executor-experimental/src/middlewares/we_opcode_trace.rs |
Adapts middleware lifetimes. |
vm-executor-experimental/src/middlewares/we_protected_globals.rs |
Adapts middleware lifetimes. |
vm-executor-experimental/tests/locals_test.rs |
Tests experimental executor boundaries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Upgrades the experimental executor to Wasmer 7.5 and adds consistent WASM-local limits and metering.
Changes:
Had to re-create the PR after a wrong merge. Original impl: #93