Skip to content

wasmer 7.5 upgrade in experimental executor - #96

Merged
andrei-marinica merged 4 commits into
rc/after-supernovafrom
wasmer7re
Oct 10, 2026
Merged

andrei-marinica merged 4 commits into
rc/after-supernovafrom
wasmer7re

Conversation

@andrei-marinica

Copy link
Copy Markdown
Contributor

Upgrades the experimental executor to Wasmer 7.5 and adds consistent WASM-local limits and metering.

Changes:

  • Updates Wasmer dependencies and middleware lifetime APIs.
  • Enforces a shared 4,000-local function limit.
  • Adds boundary tests for both executors.

Had to re-create the PR after a wrong merge. Original impl: #93

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Local metering can miscalculate costs when a 64-bit unmetered-local threshold is narrowed to u32, and the new metering path lacks coverage.

2 open findings
What changed in this PR

Upgrades the experimental executor to Wasmer 7.5 while aligning local limits and metering across executors.

Changes:

  • Updates Wasmer dependencies and middleware lifetimes.
  • Shares the 4,000-local limit and implements experimental local metering.
  • Adds boundary tests for both executors.
File Description
vm-executor/​src/​lib.rs Exports the shared local limit.
vm-executor/​src/​compilation_options.rs Defines the 4,000-local limit.
vm-executor-wasmer/​src/​wasmer_metering.rs Uses the shared limit.
vm-executor-wasmer/​tests/​locals_test.rs Tests legacy executor boundaries.
vm-executor-experimental/​Cargo.toml Upgrades Wasmer to 7.5.
vm-executor-experimental/​src/​middlewares/​we_breakpoints.rs Adapts middleware lifetimes.
vm-executor-experimental/​src/​middlewares/​we_metering.rs Adds local limits and metering.
vm-executor-experimental/​src/​middlewares/​we_opcode_control.rs Adapts middleware lifetimes.
vm-executor-experimental/​src/​middlewares/​we_opcode_trace.rs Adapts middleware lifetimes.
vm-executor-experimental/​src/​middlewares/​we_protected_globals.rs Adapts middleware lifetimes.
vm-executor-experimental/​tests/​locals_test.rs Tests experimental executor boundaries.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread vm-executor-experimental/src/middlewares/we_metering.rs Outdated
Comment thread vm-executor-experimental/src/middlewares/we_metering.rs
@andrei-marinica
andrei-marinica merged commit a6a8441 into rc/after-supernova Oct 10, 2026
7 checks passed
@andrei-marinica
andrei-marinica deleted the wasmer7re branch October 10, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants