Fix #1073: toJSON incorrectly wraps single table in array - #5192
Open
0xSenior wants to merge 1 commit into
Open
Conversation
Problem:
- toJSON({ key = value }) returned '[{...}]' instead of '{...}'
- WriteToJSONString() always called WriteToJSONArray(), wrapping
all results in a JSON array even for single table arguments
Solution:
- Check if there is exactly one argument and it is a table (LUA_TTABLE)
- If so, serialize it directly using WriteToJSONObject() instead of
wrapping it in an array via WriteToJSONArray()
- Otherwise, fall back to existing array behavior
Files changed:
- Client/mods/deathmatch/logic/lua/CLuaArguments.cpp
- Server/mods/deathmatch/logic/lua/CLuaArguments.cpp
This fix maintains backward compatibility for multiple arguments
and non-table single arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Files changed:
This fix maintains backward compatibility for multiple arguments and non-table single arguments.
Summary
Motivation
Test plan
Checklist