Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
422 Unprocessable Submissionresponse toPOST /evaluate. An evaluation service returns it when the request is valid but it can't process the submission content, for example an unparseable expression. The body is the standardErrorResponsewith codeVALIDATION_ERROR.At the moment a submission the service can't interpret has to come back as
500 INTERNAL_ERROR, which clients can't tell apart from a real service failure. A separate status lets clients show the learner a fix-your-input message.Changes:
paths/evaluate/responses/422-UnprocessableSubmission.yml, in the same layout as the other evaluate responses.paths/evaluate/evaluate.ymllists"422"as a response for/evaluate.Related issue
Mirrors the 422 handling added to the Lambda Feedback evaluation function layer in lambda-feedback/BaseEvalutionFunctionLayer#21.
Scope
mainbranch, or from a fork if direct branch creation is not available.Validation
npm run lint: valid. Its 11 warnings are all already onmain; none come from this change.npm run bundleNotes for reviewers
This only adds a response, so it's backwards compatible: existing services and clients keep working. It reuses the existing
VALIDATION_ERRORcode rather than adding a new one.🤖 Generated with Claude Code