Repository navigation
Conversation
Include an empty SpcSpOpusInfo when no description or URL is supplied. Ignore -time and -st with a warning when signing. Accept both options for setting the certificate verification time when verifying.
Encode an empty Unicode file link when page hashes are disabled.
Hash the four-byte little-endian cbCabinet value after reserving the signature header. Store the hash in the serialized subject data.
Generate page hashes using the selected SHA-2 signing digest. Determine the digest width during verification from the PE page count and serialized table length. Also accept SHA-256 page hashes in signatures using SHA-384 or SHA-512.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
osslsigncode currently does not match signtool's output when signing a driver/CAB in various ways.
New Behavior
Match signtool's output exectly.
Scope of Changes
signingTimeand remove-timeargument, signtool never emit this attribute<<Obsolete>>is never emitted by signtool and fix object id)Testing
Additional Notes
Technically a breaking change, but the
signingTimeattribute is never emitted by signtool and discarded during verification (timestamp countersigning is used instead).License Declaration