Repository navigation
Conversation
Only http:// CRL distribution points are downloaded. A signer or timestamp certificate whose distribution points all use other schemes, such as https:// or ldap://, was accepted without a revocation check and without any indication, while an unreachable http:// distribution point makes verification fail. Print a warning that lists the unsupported distribution points and suggests -CRLfile or -TSA-CRLfile. Verification results are unchanged: failing instead would break certificates with LDAP-only distribution points, such as those issued by some Active Directory Certificate Services deployments. Certificates without CRL distribution points are not affected.
mtrojnar
force-pushed
the
warn-unsupported-cdp
branch
from
November 18, 2026 08:44
f24b27f to
d742635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
verifydownloads CRLs only fromhttp://CRL distribution points. If a signer or timestamp certificate lists onlyhttps://,ldap://, or other distribution points, revocation is silently not checked and verification succeeds. An unreachablehttp://distribution point, by contrast, makes verification fail.New Behavior
When no CRL is available, a warning lists the unsupported distribution points and suggests
-CRLfileor-TSA-CRLfile:The warning is not printed with
-ignore-crl, or when CRLs are available from-CRLfile/-TSA-CRLfileor the signature.Scope of Changes
Verification results are unchanged. Failing instead would break certificates with LDAP-only distribution points, such as those issued by some AD CS deployments. Certificates without CRL distribution points are not affected. The manual and NEWS now describe the
http://-only behavior.Testing
ctest: 424/424 passed. Manually verified signer certificates withhttps://,ldap://,http://, and no distribution points, a built-in TSA certificate with anhttps://distribution point, and the-CRLfile,-TSA-CRLfile,-ignore-crl, and-ignore-cdpoptions.License Declaration