Skip to content

Warn when no CRL distribution point uses http:// - #537

Open
mtrojnar wants to merge 1 commit into
masterfrom
warn-unsupported-cdp
Open

mtrojnar wants to merge 1 commit into
masterfrom
warn-unsupported-cdp

Conversation

@mtrojnar

Copy link
Copy Markdown
Owner

Pull Request Type

  • Bug fix
  • New feature
  • Code style / formatting / renaming
  • Refactoring (no functional or API changes)
  • Build / CI related changes
  • Documentation
  • Other (please describe):

Related Issue

Issue number: N/A

Current Behavior

verify downloads CRLs only from http:// CRL distribution points. If a signer or timestamp certificate lists only https://, ldap://, or other distribution points, revocation is silently not checked and verification succeeds. An unreachable http:// distribution point, by contrast, makes verification fail.

New Behavior

When no CRL is available, a warning lists the unsupported distribution points and suggests -CRLfile or -TSA-CRLfile:

Warning: No http:// CRL distribution point, revocation status not checked
Unsupported CRL distribution point: URI:https://crl.example/ca.crl
Use the "-CRLfile" option to add one or more CRLs in PEM format.

The warning is not printed with -ignore-crl, or when CRLs are available from -CRLfile/-TSA-CRLfile or the signature.

Scope of Changes

Verification results are unchanged. Failing instead would break certificates with LDAP-only distribution points, such as those issued by some AD CS deployments. Certificates without CRL distribution points are not affected. The manual and NEWS now describe the http://-only behavior.

Testing

  • Existing tests
  • New tests added
  • Manual testing

ctest: 424/424 passed. Manually verified signer certificates with https://, ldap://, http://, and no distribution points, a built-in TSA certificate with an https:// distribution point, and the -CRLfile, -TSA-CRLfile, -ignore-crl, and -ignore-cdp options.

License Declaration

  • I hereby agree to license my contribution under the project's license.

Only http:// CRL distribution points are downloaded.  A signer or
timestamp certificate whose distribution points all use other schemes,
such as https:// or ldap://, was accepted without a revocation check and
without any indication, while an unreachable http:// distribution point
makes verification fail.

Print a warning that lists the unsupported distribution points and
suggests -CRLfile or -TSA-CRLfile.  Verification results are unchanged:
failing instead would break certificates with LDAP-only distribution
points, such as those issued by some Active Directory Certificate
Services deployments.  Certificates without CRL distribution points are
not affected.
@mtrojnar
mtrojnar force-pushed the warn-unsupported-cdp branch from f24b27f to d742635 Compare November 18, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant