Repository navigation
Conversation
step-security/msvc-dev-cmd fails in private repositories unless the owner has a StepSecurity subscription, which it checks by sending the repository name to StepSecurity's API. This breaks every Visual Studio CI job in private development forks. Run Visual Studio's own vcvarsall.bat instead and export the variables it changes, which is what the action did. This removes a third-party dependency from both CI and release builds.
Code scanning of private repositories requires GitHub Code Security, which is unavailable on the GitHub Free plan. Without it, every CodeQL run fails at upload after analyzing the code. Public repositories keep scanning on every push, pull request, and schedule.
macOS runner minutes cost about six times as much as Windows minutes and are about half the cost of a CI run with warm caches, which quickly exhausts the included Actions usage of private repositories. Changes developed there are mostly portable and still get Linux and Windows coverage. Move macOS to a separate job that reuses the build steps, so it can be skipped in private repositories unless CI is run manually. Public repositories keep building on macOS for every push and pull request, under the same check name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI does not work in private copies of this repository on the GitHub Free plan. Every Visual Studio job fails because
step-security/msvc-dev-cmdrequires a paid StepSecurity subscription in private repositories, and CodeQL fails because code scanning there requires GitHub Code Security. macOS jobs also account for about half the cost of a CI run, which quickly uses up the included monthly Actions usage.Fix
vcvarsall.batin CI and release builds, removing the third-party action.This repository runs the same jobs as before.
Validation
In a private repository, the PR run passed with macOS and CodeQL skipped, and a manual CI run passed with macOS under its usual check name. All three Visual Studio jobs passed in both. The release workflow change has not been run.