test(recover): exercise the unsourced regression on an applied recover - #10
Merged
Merged
Conversation
The regression test added with the fix asserted verdicts from a dry-run over injected MemoryRecord objects. That does not guard the defect: recover applies by default (dry_run=False on the CLI path), and applying is what wiped stores. Replaced with a real end-to-end case - three memories written to a live store with no source on any row, an applied recover, then a recall-back assertion that they are genuinely still retrievable rather than merely un-purged in the report. The opt-in path gets the same applied treatment. Verified by mutation: reintroducing the bug makes the new test fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9.
The regression test that shipped with the fix asserted verdicts from a dry-run
over injected
MemoryRecordobjects. That does not guard the defect —recoverapplies by default (
dry_run=False), and applying is what wiped stores. A test thatonly exercises the dry-run path would have passed against the buggy code.
Replaced with a real end-to-end case:
sourceon any rowreported as un-purged
The opt-in
purge_unsourced=Truepath gets the same applied treatment.Verified by mutation: reintroducing the bug (
if purge_unsourced:→if True:)makes the new test fail; reverting makes all 14 pass. The previous version passed either way.